Audacity Bug Summary
••• Introduction •••
••• Keywords •••
    Audacity 3.0.3 development began 19th April 2021

Audacity Bugzilla



Bug 2544 - "Editing a clip can move other clips" turned off can cause corruption when copying and pasting audio
"Editing a clip can move other clips" turned off can cause corruption when co...
Status: RESOLVED FIXED
Product: Audacity
Classification: Unclassified
Component: Application Core
3.0.0
All All
: P1 RepeatableAll
Assigned To: Default Assignee for New Bugs
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2020-09-13 08:11 UTC by Peter Sampson
Modified: 2020-11-30 08:04 UTC (History)
7 users (show)

See Also:
Steps To Reproduce:
1) In Tracks Behaviors prefs uncheck "Editing a clip can move other clips" 2) import/generate some stereo audio 3) zoom out once (just to give some space) 4) Insert a split say half way through the audio to create 2 clips 5) shift the second clip along a small amount 6) select a reasonably sized section from the second clip 7) Copy that to the Audacity clipboard 8) select a smaller section in the first clip 9) try pasting the clipboard contents 10) Observe: Error message - There is not enough room available to paste the selection 11) Observe: Clip-1 has been damaged with extra audio in the right channel 12) Observe: for some odd reason Play icon has changed to Play Cut Preview 10 is expected behavior - 11 & 12 are definitely not and are erroneous
Release Note:
First Git SHA:
Group: ---
Workaround:
Closed: 2020-11-26 00:00:00
petersampsonaudacity: Test‑OK‑Win+
petersampsonaudacity: Test‑OK‑Mac+
stevethefiddle: Test‑OK‑Lin+


Attachments
Copy Paste bug with clips (47.86 KB, image/png)
2020-09-13 08:11 UTC, Peter Sampson
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Sampson 2020-09-13 08:11:13 UTC
Created attachment 1005 [details]
Copy Paste bug with clips

When "Editing a clip can move other clips" turned off in Tracks Behaviors prefs this can cause corruption when copying and pasting audio that is too large for the target location.
a) extra audio gets added to the right channel (see attachment)
b) the channels go out of sync in part
c) the Play button oddly gets change to Play Cut Preview

Clicking OK on the error message (step 10) corrects the play button but the right channel audio corruption remains.

Oddly if at step 8 you just make a point selection in Clip-1 and the Paste the error does not occur.


Only tested on W10 so far but assume all platforms.

This is not a regression on 2.4.2 as it happens there too.  I have not yet tested further back to see if this is a regression
Comment 1 Peter Sampson 2020-09-13 12:05:38 UTC
Similar behavior goes all the way back to 2.0.0, bet here Audacity repairs itself:

in 2.0.0 you get not one but two error messages, one after the other, telling you that there is not enough room

a) the first one appears and the audio is similarly corrupted as in 3.0.0/2.4.2

b) the Play button is not changed it remains as plain Play

c) dismissing this first message causes Audacity to repair the right-channel and
displays the second insufficient space message.
Comment 2 Peter Sampson 2020-10-11 11:46:44 UTC
Upgraded to P1 following discussion with RM
Comment 3 Bill Wharrie 2020-11-17 18:28:08 UTC
Did this get fixed somewhere? I can't reproduce this with 8ac1cb7 on Mac Catalina.
Comment 4 Peter Sampson 2020-11-18 06:38:22 UTC
(In reply to Bill Wharrie from comment #3)
Testing on W10 with  Audacity 3.0.0 0277e00

I still get corruption in the first clip in the left channel - it gets made shorter (from the left).

So no I don't think it's fixed.
Comment 5 Steve Daulton 2020-11-19 06:01:52 UTC
Should step 4 be:
4) Inset a SPLIT say half way through the audio?
Comment 6 Steve Daulton 2020-11-19 06:11:23 UTC
I'm not able to reproduce this on Linux. Perhaps the steps to reproduce need to be more precise, or perhaps it's platform dependent.

I CAN still reproduce Bug 2581.
Comment 7 Paul L 2020-11-25 11:46:25 UTC
Fixed at 7a1ca42109a8b4d0627c5429e9e72311252054fc
Comment 8 Paul L 2020-11-25 11:59:55 UTC
As with 2581, whether the bug reproduces in the commits before my fix, depends on whether you paste with a shortcut key (yes) or using the menu (no)
Comment 9 Peter Sampson 2020-11-25 12:45:11 UTC
(In reply to Paul L from comment #7)
Tested on W10 with Audacity 3.0.0 7a1ca42

This now works properly with both stereo and mono tracks
a) the error message is displayed properly
b) there is no corruption
c) the Play icon remains unchanged

I tested both with Ctrl+V shortcut and Edit>Paste
Comment 10 Peter Sampson 2020-11-25 12:49:58 UTC
(In reply to Paul L from comment #7)
Tested on macOS 11.0.1 Big Sur with Audacity 3.0.0 7a1ca42

As with Windows this now works properly on Mac with both stereo and mono tracks
a) the error message is displayed properly
b) there is no corruption
c) the Play icon remains unchanged

I tested both with Cmd+V shortcut and Edit>Paste
Comment 11 Steve Daulton 2020-11-26 12:40:27 UTC
The bug as described appears to be fixed, though the "Editing a clip can move other clips" setting appears to ignored when Sync-Lock is enabled.

I'll close this bug as fixed and raise the remaining issue as a separate bug.
Comment 12 Paul L 2020-11-26 13:38:49 UTC
(In reply to Steve Daulton from comment #11)

But see what James did at commit 2d2f282c83574a39f4935d93b5ca1a13f7f9c806 to address bug 825, intentionally overriding the preference when there is sync-lock.

There would seem to be inherent conflict between the sync-lock feature and this preference.
Comment 13 Steve Daulton 2020-11-30 08:04:06 UTC
(In reply to Paul L from comment #12)
Yes indeed.
If you have any ideas how to resolve the inherent conflict, please post to the QA list - I really dislike such conflicts and would be very interested to hear possible solutions.