Bugzilla – Bug 2547
Shift + Click may select incorrect tracks
Last modified: 2021-02-14 09:44:55 UTC
1. Create a project with two audio tracks. 2. "Ctrl + A" to select all 3. "Ctrl + Click" on the "Select" button of the second track to de-select it. 4. "Up" key to move focus to the first track 5. "Shift + Click" on the first track to adjust the end of the selection. 6.Observe that the second track becomes selected again. In my opinion, step 4 should be irrelevant because we are selecting with the mouse. In the above case, step 5 should adjust the selection in the currently selected track. In the general case, I think that shift + click should adjust the length of the selection in all selected tracks, and the track that is clicked.
Fix in: https://github.com/audacity/audacity/commit/0c23435
(In reply to Leland Lucius from comment #1) > Fix in: > > https://github.com/audacity/audacity/commit/0c23435 This fix has changed to behaviour of the move focus to next/previous track commands. Prior to the fix, the selection of the tracks was unchanged. Robert has made the suggestion that the behaviour of these commands might be changed in the future, but this would need further discussion, and now in not the time to change the behaviour.
Tested on W10 and macOS 11.2.1 Bug Sur with Audacity 3.0.0 b928e7e This now behaves properly on both platforms - at Step 6 the second track does not become selected. I also observed the errant behavior in 2.4.2
So although this bug as described is now "fixed" - I shall hold off closing this until we resolve David's compalint abot change behavior in Comment #2
Re Comment 2: Moving selection and focus together seems logical to me, though perhaps it might mean an update is required to some Jaws or other script. I suspect the change is neutral or an improvement. I think the discussion should be had, and now. If there is no clear consensus, then Leland's fix stands and we close this bug.
(In reply to James Crook from comment #5) I can see David's point. Previously, "Move focus to next track" was consistent with "Move focus to last track", in that it moved focus only (the selection did not change). Now, "Move focus to next track" and "Move focus to last track" are NOT consistent. "Move focus to last track" moves focus only (the selection did not change). "Move focus to next track" moves focus AND the selection. Consistency is good.
(In reply to Steve Daulton from comment #6) Actually there is a regression (mainly for VI users) with this change See: https://alphamanual.audacityteam.org/man/Audio_Tracks#panel This means that it is difficult/impossible for VI users now to make multiple tracks selected unless they are contiguous. Try it with four mono tracks start with the fourth selected and try then to also select tracks one or two A) In 2.4.2 a) select 4th track b) up-arrow c) Observe Focus moves to track 3, but track 4 remains selected d) up-arrow e) Observe Focus moves to track 3, but track 4 remains selected d) Enter e) Observe: now track and track 4 are selected B) now with 3.0.0 a) select 4th track b) up-arrow c) Observe: focus move to track 3 but so does selection So this may make life tougher for VI folk - or keyboard warriors
(In reply to Peter Sampson from comment #7) Because of the changed behavior elsewhere as reported by David in Comment #2 and the use case in Comment #4 that illustrates the downside of that change, this fix must either: a) be reverted, or b) be fixed in a different way such that the behavior of the up/down arrows with focused tracks remains only moving the focus and not the selection,
As I don't see another way to do it "quickly" without having some discussions, I've reverted here: https://github.com/audacity/audacity/commit/5f68102
