Bug 2557 – Spectrogram settings: setting Zero Padding before selecting algorithm Pitch(EAC) can cause a crash

••• Introduction •••
••• Keywords •••

Audacity 3.0.3 development began 19th April 2021

Audacity Bugzilla

Bug 2557 - Spectrogram settings: setting Zero Padding before selecting algorithm Pitch(EAC) can cause a crash


Summary:	Spectrogram settings: setting Zero Padding before selecting algorithm Pitch(E...

Status:	RESOLVED FIXED

Product:	Audacity
Classification:	Unclassified
Component:	Application Core
Version:	3.0.0
Hardware:	All All

Importance:	P1 RepeatableAll
Assigned To:	Paul L

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2020-10-01 10:01 UTC by Peter Sampson
Modified:	2020-10-06 06:09 UTC (History)
CC List:	7 users (show)

See Also:	2554
Steps To Reproduce:	0. clear Audacity settings folder 1. Launch Audacity 2. Generate a 30 second Chirp 3. Change the track view to Spectrogram 4. Open Spectrogram settings 5. Set Zero Padding = 4 6. Set Algorithm = Pitch(EAC) 7. Click "OK" button 8. Crash
Release Note:
First Git SHA:
Group:	---
Workaround:
Closed:	2020-10-06 00:00:00

Flags:	petersampsonaudacity: Regression+ petersampsonaudacity: Test‑OK‑Win+ petersampsonaudacity: Test‑OK‑Mac+ stevethefiddle: Test‑OK‑Lin+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Peter Sampson 2020-10-01 10:01:44 UTC

In Spectrogram settings setting Zero Padding before selecting algorithm Pitch(EAC) can cause a crash.

Observe that if you instead change the algorithm to Pitch(EAC) first then Zero Padding is grayed-out and cannot be changed.


On macOS 10.15.6 with Audacity 3.0.0 8c1152e
This causes 
a) a crash
b) spinning beach-ball-of-death
c) a force quit is required

On 2.4.2 with Mac these steps produce a silent crash.



On W10 with 2.4.2 these steps produce a crash 

But on Audacity 3.0.0 8c1152e on W10 there is no crash but the spectrogram view is blank

Comment 1 Peter Sampson 2020-10-01 12:05:36 UTC

Basically if the Zero Padding is set to anything other than its default 1 - the the algorithm "Pitch(EAC)" needs to be grayed-out and unavailable (or at least blocked with an error message).

Comment 2 Paul L 2020-10-05 13:36:22 UTC

You discovered a hidden corner case in a very old (2.1.3) development development of mine that led to memory overwrites!

Fixed at
https://github.com/audacity/audacity/commit/9b6fc0f152a73f8fb365d14ac432f146f4c9f188

Comment 3 Peter Sampson 2020-10-06 05:31:08 UTC

(In reply to Paul L from comment #2)
Testing on W10 with Audacity 3.0.0 22dbe0a

This now does not cause a crash - so on W10 this particular bug is fixed.  So marked as "+" on Windows




But P1 regression Bug #2556 
Spectrogram view: changing algorithm to Pitch (EAC) or Reassignment changes view to grayscale and Period 

and P1 regression Bug #2554
Spectrogram view: changing algorithm to Pitch (EAC) or Reassignment prevents reversion to Frequencies algorithm

still afflict Spectrogram view

Comment 4 Peter Sampson 2020-10-06 05:58:46 UTC

Testing on macOS 10.15.6 with Audacity 3.0.0 22dbe0a

This now does not cause a crash - so on Mac this  bug is fixed.  So marked as "+" on Mac.

Comment 5 Steve Daulton 2020-10-06 06:09:21 UTC

The issue as described also works correctly on Linux, so closing as resolved fixed.