Audacity Bug Summary
••• Introduction •••
••• Keywords •••
    Audacity 3.0.3 development began 19th April 2021

Audacity Bugzilla



Bug 2558 - Clip left/right commands can fail to move the cursor
Clip left/right commands can fail to move the cursor
Status: RESOLVED FIXED
Product: Audacity
Classification: Unclassified
Component: User Interface
3.0.0
PC Windows 10
: P3 Repeatable
Assigned To: Default Assignee for New Bugs
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2020-10-02 09:08 UTC by David Bailes
Modified: 2020-10-08 08:31 UTC (History)
9 users (show)

See Also:
Steps To Reproduce:
1. Create some audio in a track. 2. The track should be selected and the focus. 3. Press k to move the cursor to the end of the clip. 4. Extra > Cursor > Clip right. 5. The clip moves, but the cursor does not. There's a corresponding problem is you move the cursor to the start of the clip and execute clip left.
Release Note:
To be provided
First Git SHA:
Group: Accessibility
Workaround:
Closed: 2020-10-08 00:00:00
drbailes: Must‑Test‑All‑OS-
petersampsonaudacity: Regression+
petersampsonaudacity: Test‑OK‑Win+
petersampsonaudacity: Test‑OK‑Mac+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Bailes 2020-10-02 09:08:30 UTC
See steps to reproduce.
This is a regression.
Although the error is only one pixel, the time error could be significant when zoomed out.


The problem is in these lines in DoClipMove(). interval contains the start and end of the clip BEFORE the move.

         auto &intervals = pShifter->MovingIntervals();
         if ( !intervals.empty() ) {
            auto &interval = intervals[0];
            if (newT0 < interval.Start())
               newT0 = interval.Start();
            if (newT0 > interval.End())
               newT0 = interval.End();
            double diff = selectedRegion.duration();
            selectedRegion.setTimes(newT0, newT0 + diff);
         }
Comment 2 David Bailes 2020-10-07 08:43:00 UTC
There was also an identical problem with notetracks (except there can be only one "clip"). The above fix, also fixes that problem.
Comment 3 Peter Sampson 2020-10-08 08:28:56 UTC
(In reply to David Bailes from comment #1)
Tested on W10 with Audacity 3.0.0 7186aaf

the clip and the cursor now move.
Comment 4 Peter Sampson 2020-10-08 08:31:50 UTC
(In reply to David Bailes from comment #1)
Tested on macOS 10.15.6 with Audacity 3.0.0 7186aaf

the clip and the cursor now move.  So OK on Mac as well