Fix at 5ebfe4670ce0415e4a040af2645bb899bbb27d14

File fails to open but the error dialog is not empty

I note that in my example, the project is not irretrievable.  Opening can succeed if the triple of .aup3, -wal, and -shm files are copied from the small drive onto the Macbook's more spacious SSD and then opened.

So it seems it is only device space limitation, not the file contents, at fault when reopening, causing sqlite errors.  Sqlite still did a good job of satisfying the D of ACID guarantees.

In my various testings today after the latest round of Disk-full bug fixes I have not seen such blank error messages when reopening salvaged files after disk space exhaustion.

I'm not sure what the full steps to reproduce might be - but AFAICT this seems to be working

Testing again on W10 with Audacity 3.0.0 f5fd860

I still do bot see such blank messages - tested today with NTFS formatted USB clip

So WORKSFORME

Paul wrote in the steps:
>But I think it happens only when there is a -shm file, 
>which happens on Mac only in modified builds.

I don't have such a modified build, so I never see SHM files on Mac.


Nor have I seen the "Blank error message when reopening files after drive space exhaustion" - and I have done an awful lot of disk soace exhaustion testing.


So WORKSFORME on Mac as well as windows

I have never seen this exact problem on Linux. Paul, are you sure that this bug is "Repeatable All" and not Windows + Modified Mac only?

(In reply to Steve Daulton from comment #5)
>Paul, are you sure that this bug is "Repeatable All" and not Windows 
> + Modified Mac only?

I have never seen this on W10 - and I've done a *LOT* of disk full testing

(In reply to Steve Daulton from comment #5)

It was rare and repeatable only in special cases.  I know I saw it happen on Mac, when exhausting space on an external device, but also modifying my build to use -shm files.

so can we close this as WORKS-FOR-ME ?

As no-one can now reproduce the problem I'm closing as "works for me".

@ Paul, if you have any doubts about the fix, please reopen (I'm assuming that you are happy with the 5ebfe fix).