Audacity Bug Summary
••• Introduction •••
••• Keywords •••
    Audacity 3.0.3 development began 19th April 2021

Audacity Bugzilla



Bug 262 - Enh: Mixer Board: Track strip and border colours to match those in current TrackPanel
Enh: Mixer Board: Track strip and border colours to match those in current Tr...
Status: RESOLVED FIXED
Product: Audacity
Classification: Unclassified
Component: User Interface
1.3.14 alpha
PC All
: P4 Enhancement
Assigned To: Default Assignee for New Bugs
: patch
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-12-05 09:57 UTC by Gale Andrews
Modified: 2018-08-20 11:45 UTC (History)
5 users (show)

See Also:
Steps To Reproduce:
A1. Start Audacity, with Classic theme, and add three tracks. A2. Select the second track. A3. Open the mixer board. Notice that the track selectedness is not reflected in colour changes in the mixer board (only by 3D pop-up/down effect)
Release Note:
First Git SHA:
Group: ---
Workaround:
Closed: 2018-08-20 00:00:00


Attachments
Patch for bug 262 by Matthew Lannan (6.35 KB, patch)
2014-04-01 14:10 UTC, Gale Andrews
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gale Andrews 2010-12-05 09:57:59 UTC
paraphrasing Vaughan:
Mixer Board code was originally in a branch off 1.2.6, and ported to trunk after 1.3 track border color changes had been made in TrackPanel. So Mixer Board strip and border colours should be changed to match the current ones in TrackPanel.
Comment 1 Gale Andrews 2010-12-05 10:01:36 UTC
The main user problem resulting is that they find it hard to realise which tracks in Mixer Board are selected.
Comment 2 Gale Andrews 2014-04-01 14:10:11 UTC
Created attachment 476 [details]
Patch for bug 262 by Matthew Lannan

Patch compiles on Windows. Not tested elsewhere. 

I am unclear why a bright colour like green is chosen for the mbTrackSelectedColor()bevel colour. This makes it look like a focus colour in the way that yellow is focus colour in the Track Panel tracks, but it is actually the track selected colour. 

Personally I would find it more intuitive if the selected Mixer Board track strips had the same track selected colour as in the Track Panel, and only the focused track strip had the bevel colour. That way it would be clearer which Mixer Board strip has the focus - if you TAB into the icon you cannot tell at all which strip has focus.
Comment 3 Peter Sampson 2016-12-07 05:32:37 UTC
I have just been updating the documentation for Mixer Board and it looks to me as if nothing has been done to improve the visual cue to indicate track selection in the Mixer Toolbar.
http://alphamanual.audacityteam.org/man/Mixer_Board

The current visual cue is (quoting from the Manual, I added this today): "Selection of a track in Mixer Board is indicated by the gray half-border that sits right and bottom of an unselected track moves to left and top of a selected track".

This visual cue is far too subtle and is very unlike the indicators of selection in the tracks in the Audacity window where we turn selected tracks dark gray.  

For consistency, and for a stronger visual cue,I think we should be using the same dark gray visual cue for selected tracks in Mixer Board.
Comment 4 Steve Daulton 2016-12-07 06:11:40 UTC
(In reply to Gale Andrews from comment #1)
> The main user problem resulting is that they find it hard to realise
> which tracks in Mixer Board are selected.

Why do we need to show or control track selectedness in the Mixer Board? What can you do from the Mixer Board that depends on track selection?

Testing on Linux Xfce, only about 30% of a "mixer strip" area effects a change of track selection. The "hot spots" are:

* To the right of the Gain slider (but not 'on' the Gain slider)
* The border (extreme edges) of a mixer strip
* The Audacity/Instrument icon
* A small area immediately above the icon
* The area to the left / right of the icon

Clicking anywhere else in the Mixer Board does not change the track selection.
Why bother having any "hot spots" in the Mixer Board for changing track selection at all? Why do we 'need' to change track selectedness while viewing the Mixer Board?

If there were no "hot spots" in the Mixer Board to change track selectedness, then why would we need to show track selectedness in the Mixer Board? 

if track selectedness is not relevant to the Mixer Board (and as shown above, it is not very relevant other than the existence of some "hot spots"), then indicating track selectedness is just visual "noise" (clutter).
Comment 5 Gale Andrews 2016-12-08 01:26:36 UTC
(In reply to Steve Daulton from comment #4)
In other words Vaughan (the doer) requested this bug be opened as far as I recall from that long ago and I was not the only "user" that was complaining.  

I mostly use Windows (so there is no native way to put Mixer Board on top of all, nor is there on Mac) and my main monitor is only 1280 * 1024. In those circumstances if I ever use Mixer Board I usually don't bother to third-party put it on top but have it to left of screen so that it covers the Track Control Panels when it has focus. 

So personally I appreciate and urge that it should show and change track selectedness and ideally show and change focus. Only the logo is a really good place to click to select the track without unintentionally moving a control. You can't see the slider boundaries unless you right-click. 

Is changing selectedness in Mixer Board not helpful for real-time preview effects?  

And then there is the consistency argument which I think Peter sees.  

If you want to argue for closing this bug as invalid, please do so on -quality... but I am unlikely to concur.
Comment 6 Steve Daulton 2016-12-08 04:24:28 UTC
(In reply to Gale Andrews from comment #5)
> If you want to argue for closing this bug as invalid...

I don't.

If someone wants to fix this bug by removing the track borders and hot spots, then I will probably support their decision.
Comment 7 Peter Sampson 2016-12-08 05:29:50 UTC
(In reply to Steve Daulton from comment #4)
>Why do we need to show or control track selectedness in the Mixer Board? 
>What can you do from the Mixer Board that depends on track selection?

It's not that you can do anything with the track selectedness in Mixer Board.

Rather it's that you can make and change selections from the mixer board (and these changes direclt affect the main Audacity window - and thus it makes eminent sense to show such selections more clearly in the Mixer Board.  Otherwise it makes for a fairly opaque and inconsistent GUI - and one that should be easy to fix.
Comment 8 Peter Sampson 2016-12-08 05:40:36 UTC
(In reply to Steve Daulton from comment #4)
>Why do we need to show or control track selectedness in the Mixer Board? 
>What can you do from the Mixer Board that depends on track selection?

Since this is indeed the case then another approach would be to 

a) totally abandon and inhibit the making and changing of selections from the Mixer Board

b) not bother showing any selectedness in the Mixer Board.
Comment 9 Peter Sampson 2016-12-10 08:15:31 UTC
The problem is exacerbated when you have many tracks and several of them selected.

The user needs to ba able to quickly and readily ascertain which of his/her tracks are slected - and the current visual cue makes this very tricky.
Comment 10 Gale Andrews 2016-12-11 21:56:20 UTC
As I already stated, 

1) You can affect real-time effect preview by changing track selectedness in Mixer Board

2) If you have Mixer Board over the main window's track control panels, which seems a way of seeing more of the waveform, then you need to see which tracks are selected in Mixer Board. 

The only way to fix the bug as titled is to do what Vaughan requested, as paraphrased in comment 0. 

But if the hot spots are a nuisance for Mixer Board users, perhaps an option could be provided to turn them off and so not allow Mixer Board to change track selectedness. Perhaps right-click over the logo on Mixer Board might be a way to offer that option.
Comment 11 James Crook 2017-05-14 17:43:31 UTC
*** STEPS ADDED ***
Comment 12 James Crook 2017-08-11 10:39:47 UTC
*** STEPS UPDATED ***

B steps fixed and removed.  A steps retained.
Converted to an Enhancement request.
Comment 14 Peter Sampson 2018-04-13 04:49:47 UTC
(In reply to James Crook from comment #13)
audacity-2.3.0-alpha-12-71f49ae0f63578abc3a9cfc6f270a0393471d1ac
and on macOS 10.13.4   audacity-macos-nightly-2.3.0-71f49ae.dmg - 28.47 MB | version: 2.3.0--13Apr18

Works fine on both platforms now.

Not sure why the steps to reproduce specifically specify using Classic theme (apart from the fact that it was Gale's, as bug reporter, obdurate choice of presentation).

Tested with all three themes Light, Dark Classic on both platforms with individual and multiple tracks selected - all OK