place some text on the system clipboard before accessing metadata editor

a) If you move to one off the blank fields and type some text
b) Observe blue focus ring round the field
c) optionally delete that text
d) Ctrl+V (CMD+V) on Mac
e) Observe:  now the system clipboard text gets pasted

Also with that blue focus border, text can be copied to the system clipboard from the metadata editor to the system clipboard.

(In reply to Peter Sampson from comment #0)
> In the Metadata editor access by either:
> a) File> Export...
> b) Edit> Metadata
> 
> 1) text cannot be cut and pasted between the fields
> 2) text that is on the clipboard prior to editing metadata cannot be pasted
> 

It actually can if you double click the destination field before pasting.

> It is worse on Mac as at Step 5 the Cmd+C actually deletes the text typed in
> at Step 3  -   this is why I gave this P2 rating as we should not be
> destroying a user's data

This was my fault as I'd swapped Copy and Cut when fixing bug 1579. You should not see this issue any longer.

(In reply to Peter Sampson from comment #1)
> place some text on the system clipboard before accessing metadata editor
> 
> a) If you move to one off the blank fields and type some text
> b) Observe blue focus ring round the field
> c) optionally delete that text
> d) Ctrl+V (CMD+V) on Mac
> e) Observe:  now the system clipboard text gets pasted
> 
> Also with that blue focus border, text can be copied to the system clipboard
> from the metadata editor to the system clipboard.

Is the system clipboard an issue?

(In reply to Leland Lucius from comment #3)
>Is the system clipboard an issue?

No -  now that I know I have to double-click in a filed to be able to "edit" rather than replace/overwrite - I can successfully paste from the system clipboard.

Tested with commit 4e6e3c on Mojave. Seems to work normally, but I notice a problem not seen before with focus.

Previously it was not required to highlight the field in blue before editing, now if that is not done then pasting affects the waveform display behind the Metadata editor. Big surprise and can mess up the project data.

I was in error regarding the need to get the field highlighted before copy/paste/cut processing, but the focus issue is new. I don't see it until the recent work on copy/paste/cut operations. New bug?

Well, sorry for the noise regarding focus. Testing more and I can not duplicate the issue. I saw it happen multiple times, but now it won't so until it pops up again, if it does, please ignore the focus issue.

(In reply to Cliff Scott from comment #5)
> Tested with commit 4e6e3c on Mojave. Seems to work normally, but I notice a
> problem not seen before with focus.
> 
> Previously it was not required to highlight the field in blue before
> editing, now if that is not done then pasting affects the waveform display
> behind the Metadata editor. Big surprise and can mess up the project data.

Bummer...Mac only again.(In reply to Cliff Scott from comment #7)
> Well, sorry for the noise regarding focus. Testing more and I can not
> duplicate the issue. I saw it happen multiple times, but now it won't so
> until it pops up again, if it does, please ignore the focus issue.

I can reproduce it and darn good thing you mentioned it. It's Mac only, but it is definitely related to fixing the cut/paste on the Open/Save dialog.

I've done a quick look into this and it appears that project windows are handling commands when they shouldn't be. However, rather than go down than rabbit hole, I may just rework the Open/Save cut/paste fix...it'd be a hack job though.

Anyway, still looking.

o reproduce the focus issue:

1) Generate chirp
2) Select a portion of the new track and copy it
3) Click somewhere in the new track to ensure it is selected
4) Open Metadata editor
5) Press CMD+V

You should see the copied samples from step 2 get pasted into the track.

(In reply to Leland Lucius from comment #9)
But this is a different new issue surely ?

(In reply to Leland Lucius from comment #9)
But I can;r reproduce this on Mac with Audacity 3.0.0 4e6e3c2

At Comment #9 Step 5 what gets pasted into the highlighted tag field fot me is the text I placed earlier on the system clipboard

Bear with me Peter/Cliff.  I was looking into resolving this, but as I suspected...big ol' can of nightcrawlers.

So, I'm reworking the Open/Save cut/paste fix and then this behavior will be gone.

Okay, I've reworked the fix for bugs 1300/1579 and that should get rid of the problem that Cliff and I were seeing here.

Looks good here with commit: 50e803 on Mojave.

So, is this bug as titled not an issue?

(In reply to Leland Lucius from comment #15)
Tested on W10 and macOS 11.1 with Audacity 3.0.0 81da0ef

Works exactly as it says in the Manual
https://alphamanual.audacityteam.org/man/Metadata_Editor#tag

So NOT-A-BUG "as titled"

But I still think the GUI in Metadata editor is a bit odd and not very "discoverable".

I may update the Manual a bit to draw more attention to the behaviors

(In reply to Peter Sampson from comment #16)
>I may update the Manual a bit to draw more attention to the behaviors

I placed the clicky behaviors in a yellow tip div - to make it more "in-your-face" to draw attention to it
https://alphamanual.audacityteam.org/man/Metadata_Editor#Tag_and_Value_fields

Peter, try your copy/cut/paste again:

https://github.com/audacity/audacity/commit/4b07fba

I like it. Now it behaves as I remember it doing. Thanks Leland.

(In reply to Leland Lucius from comment #18)
Tested on W10 with Audacity 3.0.0 4b07fba

Like Cliff, I really like it as you have it now:
a) makes it consistent with editing other text fields 
b) makes it easier to use
c) Makes it simpler to doc  (I need to update that)
d) behaves the same way as cell editing in Excel etc.

Thanks for rationalizing that Leland

(In reply to Leland Lucius from comment #18)
(In reply to Leland Lucius from comment #18)
Tested on macOS 11.1 Big Sur with Audacity 3.0.0 4b07fba

Same results as on Mac as on W10 - much better