Bug 2656 – Cannot horizontal scroll when paused in Play-at-Speed

••• Introduction •••
••• Keywords •••

Audacity 3.0.3 development began 19th April 2021

Audacity Bugzilla

Bug 2656 - Cannot horizontal scroll when paused in Play-at-Speed


Summary:	Cannot horizontal scroll when paused in Play-at-Speed

Status:	RESOLVED FIXED

Product:	Audacity
Classification:	Unclassified
Component:	User Interface
Version:	3.0.0
Hardware:	All All

Importance:	P1 RepeatableAll
Assigned To:	Default Assignee for New Bugs

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2021-02-03 16:38 UTC by James Crook
Modified:	2021-02-13 10:53 UTC (History)
CC List:	7 users (show)

See Also:	1438
Steps To Reproduce:	1) Create 30 mins of audio using chirp. 2) Zoom in three times using magnifier. 3) Start play-at-speed (x1 speed) from the start of the track. 4) Pause after two seconds or so. 5) Try to horizontal scroll with Pause still down. Observe: A) The scroll keeps returning to where the cursor is visible.
Release Note:
First Git SHA:
Group:	---
Workaround:
Closed:	2021-02-05 00:00:00

Flags:	petersampsonaudacity: Regression+ petersampsonaudacity: Test‑OK‑Win+ petersampsonaudacity: Test‑OK‑Mac+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description James Crook 2021-02-03 16:38:44 UTC

Comment 1 Peter Sampson 2021-02-03 16:50:34 UTC

Works for me on W10 with Audacity 3.0.0 eb888bb

Comment 2 James Crook 2021-02-03 19:32:26 UTC

Steps updated.  How about now?

Comment 3 Peter Sampson 2021-02-04 14:23:33 UTC

Fails for me on latest alphas and 2.4.2

Testing shows that this is a regression on 2.2.2 (introduced in 2.3.0)

Comment 4 Leland Lucius 2021-02-04 19:56:53 UTC

Weird, the timeline does change as your scrolling, so it's "half-way" working. :-)

Comment 5 Leland Lucius 2021-02-04 20:28:06 UTC

Sorry guys, I have NO idea how to fix this one. I think we're gonna need Paul's help for this bad boy.

Comment 6 James Crook 2021-02-04 21:56:35 UTC

DEVEL - FIX MADE
https://github.com/audacity/audacity/commit/0e20a0873fbfbc17b2ffd0ac0137b6fe48a2c40c

Play-at-speed uses scrubbing, and scrubbing has its own pause.
We're paused if either normal play or scrubbing play is paused.

Comment 7 Leland Lucius 2021-02-04 22:29:22 UTC

Dude, I don't know how you found that.  I was completely lost once I got into the scrubbing code.

Comment 8 Peter Sampson 2021-02-05 09:56:03 UTC

Tested on w10 and macOS 11.2 Bug Sur with Audacity 3.0.0 36126c9

Now works properly again

Comment 9 James Crook 2021-02-13 10:53:06 UTC

However, it broke autoscroll of normal playing.

This is fixed with 
https://github.com/audacity/audacity/commit/7428c61060996e9788975d165ecd9e52c5f2590a

(Which erroneously refers to bug 2565)