Bugzilla – Bug 2687
Compressor with selection to end of track can cause corruption
Last modified: 2021-03-06 14:10:27 UTC
Created attachment 1111 [details] Compressor corruption With a selection made from part way through a track to the end of a track, when Compressor is used the result is not compressed. 1) in my use case with the steps I consistently get (on both Win and Mac) the odd result in the attachment. 2) When I select from 15 secs to end I usually get a little short bit of much reduced in amplitude audio starting at 15 secs - with the remainder of the audio unchanged 3) If I select from 20 secs to end - the audio appears untouched by Compressor 4) If I select the whole track then the Compressor is applied properly. a) This is a regression against 2.4.2 - plus, b)we cannot corrupt users' audio data like this. It may be obvious visually with a test case chirp, but probably less obvious on normal audio. Hence this gets P1 status.
Cliff reported by email: >It only happens when using the default options. >Using Compression based on Peaks it works normally. Using Mojave. On W10 I still get the same 10-30 second corruption when using Compression based on Peaks
bug appears to have been introduced by this commit: Author: Leland Lucius <github@homerow.net> Date: 1 month ago (30/01/2021 07:16:32) Commit hash: 618106f1c341bc32afa833286be9cd92870a1f22 Child: b53d06ed Parent: 0576d8c9 Bug 619 - TwoPassSimpleMono converts to track bit format between passes, losing quality.
I only see the bug if the make up gain check box is checked.
Created attachment 1112 [details] More compreesor corruption I also tested with a real 4m30s minute song I selected from around 1m 30s to the end and applied Compressor. It appears to act on c. 1m30s to 3m00s leaving the last minute and a half untouched (see attachment).
You don't have to select to the end of the track to see this. Try selecting from 5 sec to 25 sec in a 30-second chirp.
Fix in: https://github.com/audacity/audacity/commit/0f830b4
(In reply to Leland Lucius from comment #6) Testing on W10 with Audacity 3.0.0 0f830b4 This looks to be fixed OK on Windows Tested with selections 1) 10-30secs 2) 15-30 3) 20-30 4) 25-30 5) 0-30 6) 10-20 7) 5-25 8) 10-60 all compress as expected
Confirmed RESOLVED FIXED
(In reply to Leland Lucius from comment #6) Testing on macOS 11.2.1 Big Sur with Audacity 3.0.0 0f830b4 This looks to be fixed OK on Mac too Tested with selections 1) 10-30secs 2) 15-30 3) 20-30 4) 25-30 5) 0-30 6) 10-20 7) 5-25 8) 10-60 all compress as expected
