Bug 284 – Audacity doesn't support using system portsmf

••• Introduction •••
••• Keywords •••

Audacity 3.0.3 development began 19th April 2021

Audacity Bugzilla

Bug 284 - Audacity doesn't support using system portsmf


Summary:	Audacity doesn't support using system portsmf

Status:	RESOLVED FIXED

Product:	Audacity
Classification:	Unclassified
Component:	Other
Version:	1.3.14 alpha
Hardware:	PC Linux

Importance:	P4 Review
Assigned To:	Default Assignee for New Bugs

URL:
Keywords:	patch

Depends on:
Blocks:	300
	Show dependency tree / graph

Reported:	2011-02-13 16:09 UTC by Benjamin Drung
Modified:	2018-08-20 11:45 UTC (History)
CC List:	3 users (show)

See Also:
Steps To Reproduce:
Release Note:
First Git SHA:
Group:	---
Workaround:
Closed:	2018-08-20 00:00:00

Attachments
portsmf-configure.patch (3.99 KB, patch) 2011-02-15 18:30 UTC, Benjamin Drung	Details \| Diff
portsmf-configure-v2.patch (3.98 KB, patch) 2011-02-15 19:12 UTC, Benjamin Drung	Details \| Diff
portsmf-configure-v3.patch (4.09 KB, patch) 2011-02-15 20:06 UTC, Benjamin Drung	Details \| Diff
portsmf-configure-v4.patch (5.17 KB, patch) 2011-02-22 12:32 UTC, Benjamin Drung	Details \| Diff
Show Obsolete (2) Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Benjamin Drung 2011-02-13 16:09:15 UTC

"./configure --with-midi=system" will always tell you "configure: error: You requested using the system libraries for PORTSMF but they are not available", because it always modifies PKG_CONFIG_PATH to find the local pkg-config file first. m4/audacity_checklib_widgetextra.m4 should be modified to only set PKG_CONFIG_PATH if the system library is not requested.

Comment 1 Benjamin Drung 2011-02-15 18:30:32 UTC

Created attachment 76 [details]
portsmf-configure.patch

Here's the patch to detect the system portsmf version.

Please don't forget to update configure after applying the patch.

Comment 2 Benjamin Drung 2011-02-15 19:12:50 UTC

Created attachment 77 [details]
portsmf-configure-v2.patch

Updated patch (fixed copy-paste mistake).

Comment 3 Benjamin Drung 2011-02-15 19:35:25 UTC

The PKG_CHECK_MODULES for the local .pc file does not work as expected, because $PORTSMF_LIBS and $PORTSMF_CFLAGS contains the information for dynamic linking, but you want to link the local library statically!

Comment 4 Benjamin Drung 2011-02-15 20:06:00 UTC

Created attachment 78 [details]
portsmf-configure-v3.patch

Updated patch again (forgot to add PORTSMF_SYSTEM_OPTOBJS).

Comment 5 Benjamin Drung 2011-02-22 12:32:23 UTC

Created attachment 92 [details]
portsmf-configure-v4.patch

Updated patch. If portSMF is installed in the system and a local portSMF is requested, Audacity really uses the local portSMF.

Comment 6 Benjamin Drung 2011-03-29 16:57:21 UTC

The fix was committed in r11038 and will be in audacity 1.3.13.