Bug 305 – Analysis effects produce false indication that a label is open for editing

••• Introduction •••
••• Keywords •••

Audacity 3.0.3 development began 19th April 2021

Audacity Bugzilla

Bug 305 - Analysis effects produce false indication that a label is open for editing


Summary:	Analysis effects produce false indication that a label is open for editing

Status:	RESOLVED FIXED

Product:	Audacity
Classification:	Unclassified
Component:	Labels
Version:	1.3.14 alpha
Hardware:	Per OS Other

Importance:	P4 RepeatableAll
Assigned To:	Default Assignee for New Bugs

URL:
Keywords:	labels

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2011-03-05 01:09 UTC by Gale Andrews
Modified:	2018-08-20 11:45 UTC (History)
CC List:	4 users (show)

See Also:
Steps To Reproduce:	1 Click in a digit in Selection Toolbar. 2 Choose and run an effect from the Analyze menu that creates a label e.g. Regular Interval Labels. 3 The first label appears to be open for editing and has a false cursor at the end of the label text. However use up arrow to verify that the focus actually remains in the Selection Toolbar as indicated.
Release Note:
First Git SHA:
Group:	---
Workaround:
Closed:	2018-08-20 00:00:00

Flags:	james.k.crook: Must‑Test‑All‑OS- petersampsonaudacity: Test‑OK‑Win+ petersampsonaudacity: Test‑OK‑Mac+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Gale Andrews 2011-03-05 01:09:09 UTC

* Beat Finder, Regular Interval Labels, Silence Finder and Sound Finder have the the false focus in the first label.

* Find Clipping and Sample Analyze Nyquist Plug-in have the false focus in the last label. 

On Linux and Windows, Space still plays the track while the false focus exists. 
I am "assuming" in the bug title and description that it's more useful to keep focus in the last element than move it to an arbitrary analysis label.

Comment 1 James Crook 2017-12-17 16:42:56 UTC

DEVEL - FIX MADE
https://github.com/audacity/audacity/commit/63de7f088457edd93ea58b235ee22b7d9f329320

This also fixes it for VAMP plug ins.

There perhaps should be a new bug inspired by the steps to reproduce, that moving focus from label editing to a digit in the selection toolbar does not remove focus from the label editing.  That though would be a new bug, not this one.

Main risk of this fix is that some way of creating labels that is supposed to leave focus in a label now does not.  I checked Ctrl-B and typing to create a label still work.

Comment 2 Peter Sampson 2017-12-18 09:11:11 UTC

(In reply to James Crook from comment #1)
Tested on macOS 10.13.2 High Sierra with  audacity-macos-nightly-2.2.2-63de7f0.dmg - 25.95 MB | version: 2.2.2--18Dec17

Tests ok on Mac - focus remains in the Selection Toolbar after the Regular interval labels.  Also works with Sound Finder and Silence Finder and Beat finder.

Using the up-arrow as in Step three causes the digit clicked on in Step 1 in the Selection Toolbar causes that digit to increment (correct behavior).

Comment 3 Peter Sampson 2017-12-19 05:53:13 UTC

(In reply to James Crook from comment #1)
Testing on James' 2.2.2 build of 18Dec17 on W10

As on Mac


Tests ok on Windows - focus remains in the Selection Toolbar after the Regular interval labels.  Also works with Sound Finder and Silence Finder and Beat finder.

Using the up-arrow as in Step three causes the digit clicked on in Step 1 in the Selection Toolbar causes that digit to increment (correct behavior).