Audacity Bug Summary
••• Introduction •••
••• Keywords •••
    Audacity 3.0.3 development began 19th April 2021

Audacity Bugzilla



Bug 383 - Screenshot Tools doesn't checkmark re-opened Toolbars bars in View Menu
Screenshot Tools doesn't checkmark re-opened Toolbars bars in View Menu
Status: RESOLVED FIXED
Product: Audacity
Classification: Unclassified
Component: User Interface
2.2.0
Per OS All
: P4 Review
Assigned To: Default Assignee for New Bugs
: test_single_OS
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-05-01 22:19 UTC by Gale Andrews
Modified: 2018-08-20 11:45 UTC (History)
6 users (show)

See Also:
Steps To Reproduce:
1 Uncheck all toolbars at View > Toolbars (or exit Audacity and adjust .cfg) 2 Help > Screenshot Tools. All toolbars reappear (Device Toolbar did not reappear in 1.3.12). The re-opened Toolbars are not checked at View > Toolbars. 3 Exiting after step 2 and restarting loads all the Toolbars on restart even though they are all unchecked. 4 Clicking an unchecked toolbar entry in View Menu after Step 2 makes the toolbar disappear and leaves the menu item unchecked. I assume re-opening toolbars is desirable, but the fact that they do reappear could be something to do with bug 382.
Release Note:
First Git SHA:
Group: ---
Workaround:
Closed: 2018-08-20 00:00:00
james.k.crook: Test‑OK‑Win+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Gale Andrews 2011-05-01 22:19:50 UTC
I think Screenshot Tools should just place checks for all Toolbars. A possible refinement is that if you exited Screenshot Tools while Audacity was open, it reset toolbar on/off to previous state.
Comment 1 Peter Sampson 2017-02-24 09:33:02 UTC
What appears to be happening here is that when the user invokes the Screenshot Tools Audacity then (without warning and without asking the user) resets the Toolbar positions and visible set of Toolbars to default - thereby removing the user's carefully set up Toolbar selection and positioning.

It does not appear to be a full reset as it does not seem to change the settings of values in the Toolbars (e.g. Selection Toolbar, Device Toolbar etc.)

a) I believe it is both wrong and probably unnecessary for Screenshot Tools to meddle with the users Toolbars - and as such I believe this warrants P3 rating and a Release Note.

b) Without the enhancement Proposal that I have been working on for Custom resets for Toolbar layouts there is no easy way for the user to simply restore their preferred layout:  See:
http://wiki.audacityteam.org/wiki/Proposal:_GUI_Custom_Resets_for_Toolbar_Layouts

c) The user may well be trying to make a screenshot showing a particular Toolbar layout - Screenshot Tools makes that impossible.
Comment 2 James Crook 2017-06-22 11:44:48 UTC
DEVEL - FIX MADE
https://github.com/audacity/audacity/commit/88cafa7a8971ad7f10aed693b7051bfd55ae0378

I also checked that Bug 382 hadn't come back with this change.
Comment 3 Gale Andrews 2017-06-24 20:39:18 UTC
(In reply to James Crook from comment #2)
> DEVEL - FIX MADE https://github.com/audacity/audacity/commit/88cafa7a8971ad7f10aed693b7051bfd55ae0378
> I also checked that Bug 382 hadn't come back with this change.

In my testing on Windows 10, the two "Resize..." buttons near the top of Screenshot Tools still reset toolbars to defaults on opening a new project or restarting Audacity, though this is not apparent in the checkboxes in View > Toolbars until the new project window is opened. Can we fix that too?
Comment 4 James Crook 2017-06-25 07:38:10 UTC
OK.  Re Comment #3, we now no longer reset toolbars in that case either.
https://github.com/audacity/audacity/commit/6cea9822c3064cb83574e7a137c75ffa166d1b4c
Comment 5 Gale Andrews 2017-06-28 14:16:55 UTC
"Residual" fixed.