Bugzilla – Bug 44
Modal block circumventable using taskbar and shortcuts, leading to crash risk
Last modified: 2018-08-20 11:46:09 UTC
See URL.
To clarify: The steps give you a way to get two imports going at the same time, which should not be allowed. This is possible on mac (using file > New) and on Windows (using shortcut keys and being quick). This applies not just to imports, but to any command that can be bound to a key. Leland points out "Even though we block input events to Windows, we're actually processing the keystrokes at the app level and not the window level."
From http://bugzilla.audacityteam.org/show_bug.cgi?id=334#c36 > I'm not entirely certain multiple non-OD imports every really worked > right...well, not on the Mac at least. If you got 2 going together, Audacity > would seem to hang until both of them were complete. When I have tried it on Windows I always have to force quit - the freeze seems to last much longer than you would expect the imports to take. >> So we're happy that five OD imports at the same time in different projects is >> OK (because threadsafe?) How about one OD import and one copy-in import >> (toggle the pref in the new warning before the second import)? Seems to be >> OK but I did not wait for it to finish... > That's a really good question and one I just don't know how to answer, or > rather, it makes my head hurt trying to figure out the correct answer. :-) It occurred to me that a new user could do just that, investigating the speed and display (for 30 seconds + files) differences between the two different import types.
There is a patch by Leland at http://bugzilla.audacityteam.org/show_bug.cgi?id=334#c33 to fix Windows users being able to do multiple copy-in imports by taskbar button click and shortcut. At the moment it's thought that patch fixes all other issues in the steps to repro and current bug title. "OD followed by copy-in import" being considered.
(In reply to comment #3) > There is a patch by Leland at > http://bugzilla.audacityteam.org/show_bug.cgi?id=334#c33 to fix Windows users > being able to do multiple copy-in imports by taskbar button click and shortcut. A refreshed copy is now at: http://bugzilla.audacityteam.org/show_bug.cgi?id=334#c38 At the moment it's thought that patch and others already committed in bug 334 fixes all issues in this bug, *IF* it's thought safe to start a copy-in import while an OD import is in progress...
(In reply to comment #4) Applied the patch.
Tested the steps to reproduce on Windows 7 and it seems to be fine. You cannot use shortcuts for any actions in the second project while importing in the first. Tested simultaneous imports of hour-long WAV files on Windows 7 and Ubuntu. I tested by running all imports on-demand, then one or more on-demand followed by a copy-in import. I saw no freeze issue when all imports were on-demand; when the copy-in import starts, OD imports seem to be paused but resume after copy-in completes. If there is an issue with multiple OD imports on Mac, please test and start a new bug.
