Bugzilla – Bug 465
Increase default effects preview and preview before cut
Last modified: 2018-08-20 11:51:37 UTC
Created attachment 223 [details] increases default effects preview and preview before cut Effects preview is often thought to be too short to accurately judge an effect. Because many audio editors simply preview until stopped, users may not think there is a preference to control preview length, so complain. Those that know it is a Preference have to change Preferences every time they initialise them. Preview before cut is the same length as preview after cut (1 second), but "preview before" is arguably more important to judge the cut, and 1 second is often insufficient. Patch sets effects preview to 6 seconds and preview before cut to 2 seconds. Tested OK on Win 7 that it works and initialises prefs to desired values.
(In reply to comment #0) I've applied the patch on Linux, and deleted audacity.cfg from ~/.audacity-data After building and installing, the new preview lengths do *not* take effect. To make the new settings "active" it is necessary to open and close Preferences.
Created attachment 227 [details] Corrected patch that should make new prefs work without opening prefs first
(In reply to comment #1) > After building and installing, the new preview lengths do *not* take effect. > To make the new settings "active" it is necessary to open and close > Preferences. Thanks for testing. Yes. same on Windows - I opened prefs before testing... So I searched the entire code for "AudioIO/EffectsPreviewLen" and "AudioIO/CutPreviewBeforeLen". In the attached updated patch I changed the values in ControlToolBar.cpp: gPrefs->Read(wxT("/AudioIO/CutPreviewBeforeLen"), &beforeLen, 2.0); and Effect.cpp: double previewLen = 6.0; which does now (on Win 7) make the changes work on initialised prefs before you open the Preferences window. Also tested changing to new values which works for me.
Patch applied & committed.
Thanks, Vaughan. Bill confirmed OK on Mac for completeness, so RESOLVED - FIXED.
