Bugzilla – Bug 470
Manage Curves dialog UI - buttons incorrectly enabled, resize corrupts appearance
Last modified: 2018-08-20 11:45:52 UTC
Created attachment 228 [details] Image of corrupted Manage Files dialog on OS X 10.7.2 Buttons that use or manipulate items in the list are enabled when no items are selected in the list - clicking them does nothing. The Manage Curves dialog can be made smaller and the buttons to the right of and below the list overlap the effect list - see attached image. Tested on 10.5.8 and 10.7.2.
(In reply to comment #0) > Buttons that use or manipulate items in the list are enabled when no items are > selected in the list - clicking them does nothing. I would view that another way. Shouldn't the current curve be selected when you open the dialogue, and shouldn't it be impossible to have no items in the list selected? That's how it works on Windows and Linux. > The Manage Curves dialog can be made smaller and the buttons to the right of > and below the list overlap the effect list - see attached image. Tested on > 10.5.8 and 10.7.2. I can reproduce that on Ubuntu 10.10 so platform changed to OS X and Linux. Maybe this should be a separate bug?
I cannot make an image like the attachment. However the disabling of buttons when nothing is selected, still needs to be done. Some of the buttons cause assertion dialogs if you press them with nothing selected.
Fixed https://github.com/audacity/audacity/commit/ad711e783b4f62ee5ed4474cf02080faadf7b99e I don't think this was really OS specific.
Testing on c9422aa 08Jul16 on W10 and Mac El Capitan On both platforms I don't get the overlapping buttons as shown in the attacment. But on platforms I can make the dialog pane ridiculously small, to the point of absolute unusability, in both the horizontal and vertical directions. In other parts of Audacity we seem to inhibit/prevent such overly small resizing.
On both platforms when I access the ialog "unnamed" is always selected and hence the buttons are active.
(In reply to Peter Sampson from comment #4) > on platforms I can make the dialog pane ridiculously small, to the > point of absolute unusability, in both the horizontal and vertical > directions. On Ubuntu you can collapse the dialogue leftwards so there are no window buttons visible. What about Move Up when the selected item is at the top of the list and Move Down when the selected item is directly above un-named? Should then those be greyed out, or cycle to the other end of the list? Are the active buttons that do nothing in Extended Import Preferences also a problem? They have been a problem in past history.
Also a fix from Steve for the size issue now committed: https://github.com/audacity/audacity/commit/7517b2653e2d733c399036efdcca01edb03e89a4
(In reply to James Crook from comment #7) Looks to be good on macOS 10.12.3 Sierra Gale wrote in Comment #6: >What about Move Up when the selected item is at the top of the list and >Move Down when the selected item is directly above un-named? Should then >those be greyed out, or cycle to the other end of the list? Yes I think that ideally they should be grayed out when inapproprite/unusable.
(In reply to James Crook from comment #7) And this resize sixe-limited fix works fine on W10 audacity-win-r78149bc-2.2.0-alpha-23-mar-17
I think that this should be marked "Reopened" as the residual issue that Gale refers to in Comment #5 and I commeny on in Comment #8 remains to be fixed.
(In reply to Peter Sampson from comment #8) >> Gale wrote: >>What about Move Up when the selected item is at the top of the list and >>Move Down when the selected item is directly above un-named? Should then >>those be greyed out, or cycle to the other end of the list? > Yes I think that ideally they should be grayed out when inapproprite/unusable. I'll ask on the quality-list about this.
