Bug 491 – Sliding Time Scale GUI improvements

••• Introduction •••
••• Keywords •••

Audacity 3.0.3 development began 19th April 2021

Audacity Bugzilla

Bug 491 - Sliding Time Scale GUI improvements


Summary:	Sliding Time Scale GUI improvements

Status:	CLOSED NOT-A-BUG

Product:	Audacity
Classification:	Unclassified
Component:	Built-in FX
Version:	2.0.0
Hardware:	Per OS All

Importance:	P4 Enhancement
Assigned To:	Default Assignee for New Bugs

URL:
Keywords:	patch

Depends on:	485
Blocks:
	Show dependency tree / graph

Reported:	2012-03-27 02:21 UTC by Clayton Otey
Modified:	2018-08-20 11:51 UTC (History)
CC List:	4 users (show)

See Also:	http://bugzilla.audacityteam.org/show_bug.cgi?id=485
Steps To Reproduce:	1. Try to use the new improved Sliding Time Scale GUI with output length ctrl and collapsible slide type options, an output length clamp, extreme rates, and forced automatic linking between various parameters... Result: these improvements are not there!
Release Note:
First Git SHA:
Group:	---
Workaround:
Closed:	2018-08-20 00:00:00

Attachments
This new patch includes corrected preview button changes. (250.34 KB, patch) 2012-03-27 16:22 UTC, Clayton Otey	Details \| Diff
the previous patch had CL/LR issues (80.07 KB, patch) 2012-04-05 17:55 UTC, Clayton Otey	Details \| Diff
Show Obsolete (1) Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Clayton Otey 2012-03-27 02:21:33 UTC

this patch provides GUI updates to the TimeScale dialog
The interface is similar to before, but adds
- output length ctrl
- collapsible options>> with slide type options, an output length clamp, extreme rates, and forced automatic linking between various parameters

the patch depends on sbsms2_TimeScale_nogui.patch
http://bugzilla.audacityteam.org/show_bug.cgi?id=485

Comment 1 Clayton Otey 2012-03-27 02:51:41 UTC

The preview button in this patch does not work correctly.
I will post a new patch with corrected preview button.

I could create a pre-sbsms2_TimeScale.patch preview patch, but I would like to get sbsms updated asap, so this seems like a waste of time to me.

Comment 2 Clayton Otey 2012-03-27 08:35:31 UTC

The patch will come shortly, after I resolve a minor issue.
If interested, please test the sbsms2_TimeScale_nogui.patch dependency first.

Comment 3 Clayton Otey 2012-03-27 16:22:12 UTC

Created attachment 249 [details]
This new patch includes corrected preview button changes.

Comment 4 Gale Andrews 2012-03-27 17:06:07 UTC

Thanks, Clayton.

Moved into main "Audacity" product. "Audacity Patches" product is only a fail-safe sandbox for novices without bug wrangler permissions. 

Title changed to "Sliding Time Scale GUI improvements" for consistency with bug 485.

Comment 5 Clayton Otey 2012-04-05 17:55:01 UTC

Created attachment 251 [details]
the previous patch had CL/LR issues

Comment 6 Steve Daulton 2012-04-11 12:16:15 UTC

(In reply to comment #5)
I'm getting an error with the latest patch:

patching file src/ShuttleGui.cpp
patching file src/ShuttleGui.h
patching file src/effects/TimeScale.cpp
Hunk #6 FAILED at 513.
Hunk #7 succeeded at 611 (offset 3 lines).
Hunk #8 succeeded at 640 (offset 3 lines).
Hunk #9 succeeded at 724 (offset 3 lines).
Hunk #10 succeeded at 1015 (offset 3 lines).
Hunk #11 succeeded at 1069 (offset 3 lines).
Hunk #12 succeeded at 1555 (offset 3 lines).
Hunk #13 succeeded at 1564 (offset 3 lines).
1 out of 13 hunks FAILED -- saving rejects to file src/effects/TimeScale.cpp.rej

Comment 7 Clayton Otey 2012-04-11 13:26:03 UTC

Is this with or without the sbsms2_TimeScale_nogui.patch already applied?
The patch requires first applying the latest patch from
http://bugzilla.audacityteam.org/show_bug.cgi?id=485

Comment 8 Steve Daulton 2012-04-11 17:24:53 UTC

(In reply to comment #7)
That is with corrected sbsms2_TimeScale_nogui.patch applied.

Comment 9 James Crook 2018-04-12 12:34:39 UTC

This is basically a rejected pull request.  The patch did not apply cleanly and was not got to work by the author.