Bug 513 – Contrast tool fails if selection is beyond the end of a previous track

••• Introduction •••
••• Keywords •••

Audacity 3.0.3 development began 19th April 2021

Audacity Bugzilla

Bug 513 - Contrast tool fails if selection is beyond the end of a previous track


Summary:	Contrast tool fails if selection is beyond the end of a previous track

Status:	RESOLVED FIXED

Product:	Audacity
Classification:	Unclassified
Component:	Built-in FX
Version:	2.0.0
Hardware:	PC All

Importance:	P4 Repeatable
Assigned To:	Default Assignee for New Bugs

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2012-05-27 16:11 UTC by Steve Daulton
Modified:	2018-08-20 11:45 UTC (History)
CC List:	7 users (show)

See Also:
Steps To Reproduce:	Generate a 5 second tone. Generate a 30 second tone as track 2. Select part of track 2 after 5 seconds. Open Contrast tool and measure the selection. An error is returned: "Times are not reasonable"
Release Note:
First Git SHA:
Group:	---
Workaround:
Closed:	2018-08-20 00:00:00

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Steve Daulton 2012-05-27 16:11:06 UTC

if you have a longer track below a shorter track and select valid audio in the longer track after the end of the track above, you get "Times are not reasonable!".

Comment 1 Steve Daulton 2016-03-21 20:48:10 UTC

Fixed in commit 7464f49

Comment 2 Peter Sampson 2016-03-22 06:31:30 UTC

Tested on W10 audacity-win-rff2ad78-2.1.3-alpha-22-mar-16

The issue reported here in the steps to reproduce is fixed.

Will test later on Mac when the nightly becomes available.

==============================================

But what is the error message:
"Times are not reasonable
 Please enter a reasonable time."

supposed to mean to the user - I note that it confused a user on the Forum recently - and I don't find it much clearer.

I will raise this as a separate new bug.

Comment 3 Peter Sampson 2016-03-22 06:48:02 UTC

(In reply to Peter Sampson from comment #2)
See Bug #1360 Confusing error message in Analyze contrast with invalid selection

Comment 4 Steve Daulton 2016-03-22 07:03:56 UTC

(In reply to Peter Sampson from comment #3)
Yes, quite a few bugs have accumulated in "Contrast" over the years. I'm working through them, but some are quicker to fix than others.

Comment 5 Peter Sampson 2016-03-22 07:45:53 UTC

Also tests ok on Mac El Capitan   audacity-nightly-2016.03.22-06.00-ff2ad78

Comment 6 Gale Andrews 2016-03-23 13:02:54 UTC

OK on Ubuntu 14.04. I also tried it in different projects with different instances of Contrast.