Bug 556 – Risset drum - Amount of noise in mix is 1% of the correct value

••• Introduction •••
••• Keywords •••

Audacity 3.0.3 development began 19th April 2021

Audacity Bugzilla

Bug 556 - Risset drum - Amount of noise in mix is 1% of the correct value


Summary:	Risset drum - Amount of noise in mix is 1% of the correct value

Status:	RESOLVED FIXED

Product:	Audacity
Classification:	Unclassified
Component:	Nyquist
Version:	unspecified
Hardware:	PC All

Importance:	P4 Repeatable
Assigned To:	Default Assignee for New Bugs

URL:
Keywords:	nyquist, patch

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2012-07-17 00:58 UTC by Steve Daulton
Modified:	2018-08-20 11:51 UTC (History)
CC List:	5 users (show)

See Also:
Steps To Reproduce:
Release Note:
First Git SHA:
Group:	---
Workaround:
Closed:	2018-08-20 00:00:00

Attachments
updates rissetdrum.ny (4.67 KB, patch) 2012-07-18 12:02 UTC, Steve Daulton	Details \| Diff
replacement rissetdrum.ny (2.36 KB, application/octet-stream) 2012-07-18 12:04 UTC, Steve Daulton	Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Steve Daulton 2012-07-17 00:58:35 UTC

Compared with other Risset drum samples, the amount of noise in the mix for the Audacity Risset drum is extremely low.

When set to 100% the actual noise mix level is only 1%.

There are also some consistency issues in the interface.

Comment 1 Steve Daulton 2012-07-18 12:02:42 UTC

Created attachment 296 [details]
updates rissetdrum.ny

Changes as per discussion on -quality.

* Noise Mix level adjustable from 0 to 100% (bug fix)
* Normalization bug fix.
* GUI changes as per consistency guidelines.
* Noise Mix default set to 25% (lower slider setting than previously, but audibly only a little higher than previously).
* Comment block updated as per consistency guidelines.
* Additional error checking for sensible user input.
* Code reformatted to remove excess blank lines and aid readability.
* Output level slider (Amplitude) added (default 0.8).

Comment 2 Steve Daulton 2012-07-18 12:04:36 UTC

Created attachment 297 [details]
replacement rissetdrum.ny

patched rissetdrum.ny file.

Comment 3 Vaughan Johnson 2012-07-18 19:25:31 UTC

(In reply to comment #2)

Replaced, r11855.

Comment 4 Gale Andrews 2012-07-19 19:04:24 UTC

Tested on Windows. RESOLVED - FIXED.