Bug 632 – Recordings stopped with Stop and Set Cursor cannot be undone

••• Introduction •••
••• Keywords •••

Audacity 3.0.3 development began 19th April 2021

Audacity Bugzilla

Bug 632 - Recordings stopped with Stop and Set Cursor cannot be undone


Summary:	Recordings stopped with Stop and Set Cursor cannot be undone

Status:	RESOLVED FIXED

Product:	Audacity
Classification:	Unclassified
Component:	Application Core
Version:	2.0.4
Hardware:	Per OS All

Importance:	P3 Repeatable
Assigned To:	Default Assignee for New Bugs

URL:	http://forum.audacityteam.org/viewtop...
Keywords:	patch_ready

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2013-04-06 01:46 UTC by Gale Andrews
Modified:	2018-08-20 11:51 UTC (History)
CC List:	5 users (show)

See Also:
Steps To Reproduce:	1 Start recording. 2 Stop with Stop and Set Cursor (default: SHIFT +A ). 3 Undo Record the recording is not undone.
Release Note:	GROUP:Playback and Recording * '''Recordings stopped with the "Stop and Set Cursor" shortcut''' (by default, SHIFT + A) cannot be removed by Undo.
First Git SHA:
Group:	---
Workaround:
Closed:	2018-08-20 00:00:00

Attachments
Removes unnecessary ModifyState() (390 bytes, application/octet-stream) 2013-10-04 17:21 UTC, Leland Lucius	Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Gale Andrews 2013-04-06 01:46:06 UTC

Also affects Append Record e.g. after SHIFT + R, SHIFT + A, SHIFT + R, SHIFT + A, the first Undo does nothing, second Undo deletes the second recording, first recording can't be undone.

Not a regression on 2.0.0, the bug exists there.

Comment 1 Leland Lucius 2013-10-04 17:21:47 UTC

Created attachment 401 [details]
Removes unnecessary ModifyState()

This appears to fix this issue...at least for me it does. :-)

Comment 2 Gale Andrews 2013-10-09 00:11:44 UTC

Tested on Mac and Linux, including undoing/redoing recordings in tracks underneath each other, and append record. Undo/redo after SPACE is still OK. A simple change.

Comment 3 Vaughan Johnson 2013-10-09 01:42:14 UTC

(In reply to comment #2)

Looks good to me. Please commit, Leland.

Comment 4 Gale Andrews 2013-10-09 02:59:39 UTC

Committed in r12662.