Audacity Bug Summary
••• Introduction •••
••• Keywords •••
    Audacity 3.0.3 development began 19th April 2021

Audacity Bugzilla



Bug 634 - Timeline does not zoom correctly when playback is paused
Timeline does not zoom correctly when playback is paused
Status: RESOLVED FIXED
Product: Audacity
Classification: Unclassified
Component: User Interface
unspecified
Per OS All
: P4 RepeatableAll
Assigned To: Default Assignee for New Bugs
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-04-06 22:44 UTC by Steve Daulton
Modified: 2018-08-20 11:51 UTC (History)
7 users (show)

See Also:
Steps To Reproduce:
1) Open Audacity and get some audio in a track (for example, generate a default click track) 2) Start playback 3) Pause playback 4) Zoom in horizontally. When zooming horizontally the Timeline does not zoom with the waveform.
Release Note:
First Git SHA:
Group: ---
Workaround:
Closed: 2018-08-20 00:00:00
petersampsonaudacity: Test‑OK‑Win+
petersampsonaudacity: Test‑OK‑Mac+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Daulton 2013-04-06 22:44:17 UTC
See steps to reproduce.
Comment 1 Gale Andrews 2013-04-07 16:02:10 UTC
Rated as P4 for now. 1.3.10 release does not have this issue, 1.3.11 release does. 

Scanning the changes in that period with my inexpert eye the only candidate I see that might be related is http://code.google.com/p/audacity/source/detail?r=9954  .
Comment 2 Steve Daulton 2013-04-08 05:01:23 UTC
(In reply to comment #1)
Narrowing it down a bit further - the problem seems to be due to line 1338 in TrackPanel.cpp

   // Update the indicator in case it was damaged if this project is playing
   AudacityProject* p = GetProject();
   if (!gAudioIO->IsPaused() &&
       ( mIndicatorShowing || gAudioIO->IsStreamActive(p->GetAudioIOToken())))
   {
      // We just want to repair, not update the old, so set the second param to true.
      // This is important because this onPaint could be for just some of the tracks.
      DoDrawIndicator( cdc, true);
   }


I don't know why !gAudioIO->IsPaused() is used here, but if it is removed then this problem does not occur.

   // Update the indicator in case it was damaged if this project is playing
   AudacityProject* p = GetProject();
   if ( mIndicatorShowing || gAudioIO->IsStreamActive(p->GetAudioIOToken()))
   {
      // We just want to repair, not update the old, so set the second param to true.
      // This is important because this onPaint could be for just some of the tracks.
      DoDrawIndicator( cdc, true);
   }
Comment 3 James Crook 2017-08-11 11:15:54 UTC
Still broken in 2017.
Comment 5 Peter Sampson 2017-08-15 12:05:00 UTC
(In reply to James Crook from comment #4)
Testing on macOS Sierra 10.12.6 db97fea 15Aug

Tested with
1) Ordinary Play and Pause
2) Timeline Quickplay and Pause
3) Scrubbing and Pause

a) zooming in
b) zooming out

In all 6 variant use cases the Timeline zoomed prioperly along with the waveform,

Also tested with Note Track Play and TQP with pause - all ok

Also the Timeline zooms correcty when zooming while actually playing.

Looks to be fixed ok
Comment 6 Peter Sampson 2017-08-21 11:52:04 UTC
(In reply to James Crook from comment #4)
Tested on W10 audacity-win-e984211-2.2.0-alpha-21aug17

Similar tests on Windows shows this to be fixed there too.