Bug 636 – ENTER/Return do not toggle selectedness of label track unless a label is selected

••• Introduction •••
••• Keywords •••

Audacity 3.0.3 development began 19th April 2021

Audacity Bugzilla

Bug 636 - ENTER/Return do not toggle selectedness of label track unless a label is selected


Summary:	ENTER/Return do not toggle selectedness of label track unless a label is sele...

Status:	RESOLVED FIXED

Product:	Audacity
Classification:	Unclassified
Component:	Labels
Version:	2.0.4
Hardware:	Per OS All

Importance:	P3 Repeatable
Assigned To:	Default Assignee for New Bugs

URL:	http://forum.audacityteam.org/viewtop...
Keywords:	labels, patch_ready

Depends on:
Blocks:	33
	Show dependency tree / graph

Reported:	2013-04-18 03:22 UTC by Gale Andrews
Modified:	2018-08-20 11:46 UTC (History)
CC List:	7 users (show)

See Also:
Steps To Reproduce:	1 Add some audio. 2 Tracks > Add New > Label Track. 3 Return or ENTER does not select the label track but NUMPAD_ENTER does.
Release Note:	//See Bug 33.
First Git SHA:
Group:	---
Workaround:
Closed:	2018-08-20 00:00:00

Flags:	gale: Accessibility+ gale: Regression+

Attachments
remove "Return" from IsGoodLabelFirstKey (914 bytes, patch) 2013-04-26 17:06 UTC, Steve Daulton	Details \| Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Gale Andrews 2013-04-18 03:22:05 UTC

Not an issue in 1.3.12 but is an issue in 1.3.13 and subsequently. 

If a label is selected then ENTER or RETURN still toggle selectedness.  

Does not affect Time or Note tracks.

Comment 1 Steve Daulton 2013-04-26 17:06:10 UTC

Created attachment 375 [details]
remove "Return" from IsGoodLabelFirstKey

Return key was being captured as valid for starting a label, even though not actually used to start  a label.

Comment 2 James Crook 2013-04-28 04:47:57 UTC

Patch applied.  Thanks Steve.

Comment 3 Gale Andrews 2013-04-28 15:48:41 UTC

Patch appears to have been applied as submitted, so as already tested on all platforms, RESOLVED - FIXED.