Bugzilla – Bug 637
Some full and reduced Menu Bar items are not translated
Last modified: 2018-08-20 11:45:50 UTC
In the full Audacity Menu Bar, most of the root items e.g. "File", Tracks", "View", "Transport" are translated, but "Audacity", "Window" and "Help" are not translated. In the reduced Menu bar that appears when you File > Close from the full Menu Bar, "File" is not translated. For both Menu Bars, not all items in the menu are translated e.g. the following are not translated: Audacity > Preferences * Audacity > Services Window > Zoom Window > Minimize Help > Search * Most of these are not surprising as they are not in Audacity code and are not translatable strings in the wxstd.mo files. "Preferences" is in both Audacity and in translated strings in wxstd.mo files; "Search" is only in the translated strings in the wxstd.mo files. See attached osx_menu_bar_images.zip for details.
Created attachment 372 [details] Images of Audacity, Window and Help menu on Mac in Audacity translated to Spanish
"Audacity" is trademarked, and should never be translated anywhere in our interface or documentation. This has been discussed before. A translation dilutes the trademark and is not enforceable. We do not want that. And for the others, as you note, these are not under our control. Isn't this a WONT_FIX?
Totally agreed we don't want to translate "Audacity" as a word (I should have clarified I did not mean that). But I do think this wants a complete review by a Mac developer. It is a repeated complaint and wants documenting as to what is a WONTFIX, what isn't and whether we can do better than this somehow. The following look to me as if they could be addressable, on the grounds that the untranslated words are already in Audacity, or we should examine if they can be included in Audacity defined for Mac and made to translate: Root items (Main Menu): Window Help Root items (Mini Menu): File Window Help Items in Audacity Menu Preferences Quit Audacity (not the word "Audacity") Item in Window Menu Zoom I ran Filezilla (which is a Widgets app) on Mac running in English and changed the language to Spanish in Preferences in the same way you do in Audacity. There is no Mini Menu as far as I can see but the Main Menu root items and the items within them have exactly comparable issues to those seen in Audacity. But there must be some explanation why the Main Menu "Help" and "File" root items are not translated when all the other root items that have Windows equivalents are. Also, running the Mac in the desired language does not translate any of the untranslated items. So this is not something that Apple is controlling. If it's a Widgets issue perhaps it should be reported upstream? And if necessary, should we be committing modified wxstd.po files for translation that include missing words? The latter suggestion applies also to untranslated words in common dialogues (for example, "Where" in Mac File Save dialogues). Undeniably when you compare e.g. Firefox on Mac and see a complete translation including all the offending items in this report, users will complain. Audacity > Preferences
(In reply to comment #3) > But there must be some explanation why the Main Menu "Help" and "File" > root items are not translated when all the other root items that have > Windows equivalents are. To clarify that, "File" is translated in the Main Menu, but not in the Mini Menu.
(In reply to comment #3) > running the Mac in the desired language does not translate any of the untranslated > items This is true of Audacity, but not of Filezilla. Running Mac in the desired language completes the missing Filezilla translations. So this proves that a Widgets app can translate itself fully when the Mac is running in that language (at least, if it does not have a mini menu for when the app is closed but not quit). Even if we got to that stage, it would leave a minor problem that English expatriates running the Mac in a localised language (perhaps because they do not have permission to change it to English) would get partly localised menus when running Audacity in English. But it could be that a fully localised version that (like Firefox) runs fully in its own localized language even when Mac is running in English may not be possible without a separate download for that locale.
Created attachment 386 [details] Translated menu items So, how do these look? I have some details to work out, but I believe this will be fixable. However, it may require a slight restructuring of the Audacity distribution. (Languages folder may go into the Audacity.app bundle.) But, don't know for sure yet.
(In reply to comment #6) > Created an attachment (id=386) [details] > Translated menu items > > So, how do these look? I have some details to work out, but I believe this > will be fixable. However, it may require a slight restructuring of the > Audacity distribution. (Languages folder may go into the Audacity.app bundle.) > Okay, nothing really major. No changes to the code are "required", but we'd probably want to make some small changes to be safe. And this depends on what the system language is set to. For instance, if you set the Language in System Preferences to "Deutsch", then the system control menu items (like Services or Search) will be in German. This will occur even if you don't change the Audacity language to Deutsch. This will only work if we do the following... All of the subdirectories in the Languages folder will be moved into Audacity.app/Contents/Resources/<subdir name>.lproj That's it...that's all that has to happen. You can even try it yourself. 1) Pick a language to play with, like Spanish. 2) Copy the "Languages/es" directory (and all of the contents) to "Audacity.app/Contents/Resources/es.lproj". 3) Set the system languange to Espanol. 4) Start Audacity The system controlled menu items should now be in Spanish. Now, I said above that it would probably be safer to change the code a little. If we move the Language content into the application bundle, then we'd want to protect against a user accidentally picking up an old Languages directory by "installing" Audacity to the same location and not replacing the Languages directory at the same time. We'd just need to remove the "Languages" directory from the search path for language files. No biggie really.
Created attachment 387 [details] Relocates the translation tables to the bundle This will change the location of the translation tables from: <root> Audacity.app/ Languanges/<langcode>/ to: <root> Audacity.app/Contents/Resources/<langcode>.lproj/ This will allows the menu items to be translated as expected.
Committed in r12714.
Leland, please move status to DEVEL-FIXED if you make a commit on a bug. Thanks!
Thanks, Leland. Tested on Mavericks. The only problem I still found was: > In the reduced Menu bar that appears when you File > Close > from the full Menu Bar, "File" is not translated. Are there any other apps that have that small menu bar when they are closed, that we can check it is not a Mavericks issue? I think NeoOffice may be one? I tried putting 2.0.6-alpha in the 2.0.5 "installation" folder and the wanted translations in the menu bar still appeared (with the exception above).
(In reply to comment #11) > Thanks, Leland. Tested on Mavericks. > > The only problem I still found was: > > > In the reduced Menu bar that appears when you File > Close > > from the full Menu Bar, "File" is not translated. I have no idea what that menu title was never translated. Everything around it in the source was. Must be one of those "If it was left that way, there must be a reason" kind of situations. Well, let's see what happens. :-) Fix in r12789.
(In reply to comment #12) >> In the reduced Menu bar that appears when you File > Close >> from the full Menu Bar, "File" is not translated. > Fix in r12789. With Spanish Mac system language and Audacity language set to system or Spanish, File in the reduced menu says "Archivo". When Audacity language is English and Mac system language Spanish, File in the reduced menu still says "File" whereas the two items alongside are in Spanish. So it's still slightly inconsistent. Is there any other place this should be translated?
(In reply to comment #13) > When Audacity language is English and Mac system language Spanish, File in the > reduced menu still says "File" whereas the two items alongside are in Spanish. > So it's still slightly inconsistent. Is there any other place this should be > translated? This is correct. The "File" is taken from our locale files, so when set to English we'll get English. The others are translated by OSX.
(In reply to comment #14) Leland wrote: > This is correct. The "File" is taken from our locale files, so when set to > English we'll get English. The others are translated by OSX. Thanks for confirming. RESOLVED - FIXED.
