Bugzilla – Bug 676
No prompt when clearing log.
Last modified: 2018-08-20 11:45:19 UTC
Split from bug 337. Leland said it was easy to add the version string after clear, but feel free to do or not do. That specific is probably barely a P5.
Created attachment 450 [details] Prompt user before clearing log Also adds the version string after clear.
Thanks, Steve. Tested on Mac and Windows. I like this one. Marked patch_ready.
Changed back to 'patch'. I am opposed to the first part of this patch. If I click 'Clear' I do *not* want to be asked if I really want to Clear -- I just indicated I did. I'm +1 on the new message. To be sure the new message gets to the display, the second part of this, the call to wxLogMessage should have been before the call to Flush. But I got the same result with more succinct code, http://code.google.com/p/audacity/source/detail?r=12971.
(In reply to comment #3) Vaughan wrote: > I am opposed to the first part of this patch. If I click 'Clear' I do *not* > want to be asked if I really want to Clear -1. I am very surprised as I recall you previously did not want to clear the log at all? The point of the question is obviously that you accidentally pressed clear - easily done if you use the keyboard, and easily done if user is under stress with some data loss issue where support workers need that log info. So I think this is a different case from (for example) "Clear" in Metadata Editor.
Just tested on Mac so far. If you clear the log, you see "Log Cleared." with no time. You never get the Audacity version again. OK, P6 but not helpful for support. Then when something repopulates the log after clear, the next item is on the same line as the clear so it looks like the log was cleared at the time of the next action: Log Cleared.05:16:39: File name is /Users/gale/distortionexport.wav 05:16:39: Mime type is * 05:16:39: Opening with libsndfile 05:16:39: Open(/Users/gale/distortionexport.wav) succeeded This worked better in Steve's patch IMHO: 05:27:51: Audacity 2.0.6-alpha-Nov 26 2013 05:27:51: Log Cleared. 05:28:18: File name is S:\Cover band.mp4 05:28:18: Mime type is * 05:28:18: Opening with libav 05:28:18: Open(S:\Cover band.mp4) succeeded
(In reply to comment #4) > Vaughan wrote: >> I am opposed to the first part of this patch. If I click 'Clear' I do *not* >> want to be asked if I really want to Clear > -1. > > I am very surprised as I recall you previously did not want to clear the log at > all? That's a separate question. I still think there's no strong reason for it. > The point of the question is obviously that you accidentally pressed clear > - easily done if you use the keyboard, and easily done if user is under stress > with some data loss issue where support workers need that log info. Yes, obviously, so you don't need to explain it to me. I think the nuisance of having to answer yet another alert is more harm than the putative good of baby-proofing the entire interface.
(In reply to comment #6) > > If you clear the log, you see "Log Cleared." with no time. You never get the > Audacity version again. OK, P6 but not helpful for support. Steve's patch doesn't have the time or version, it relied on other code that I didn't see. I added them, revision: 12973.
The message in the log on Clear works fine, so CLOSED WONTFIX as per title ("No prompt when clearing log"). Should we revisit this at some future time, perhaps the warning could be reinstated but turned off in debug builds so it does not annoy developers? Meantime I distance myself from the WONTFIX, sorry.
