Bug 680 – "Undo Recover" does not undo.

••• Introduction •••
••• Keywords •••

Audacity 3.0.3 development began 19th April 2021

Audacity Bugzilla

Bug 680 - "Undo Recover" does not undo.


Summary:	"Undo Recover" does not undo.

Status:	RESOLVED FIXED

Product:	Audacity
Classification:	Unclassified
Component:	Application Core
Version:	2.0.6
Hardware:	PC All

Importance:	P5 RepeatableAll
Assigned To:	Steve Daulton

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2013-11-10 10:32 UTC by Steve Daulton
Modified:	2019-08-10 12:14 UTC (History)
CC List:	4 users (show)

See Also:
Steps To Reproduce:	1) Create a project with some content. 2) "crash" Audacity in some way (on Linux this can be "killall audacity"). 3) Open Audacity and recover the project. 4) Edit > Undo Recover. The project recovery is not undone.
Release Note:
First Git SHA:
Group:	---
Workaround:
Closed:	2019-08-10 00:00:00

Flags:	petersampsonaudacity: Test‑OK‑Win+ petersampsonaudacity: Test‑OK‑Mac+ james.k.crook: Test‑OK‑Lin+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Steve Daulton 2013-11-10 10:32:38 UTC

See steps to reproduce.

Comment 1 Gale Andrews 2013-11-11 02:08:52 UTC

2.0.0 does the same. 

I've suggested P4, on the grounds user could forget recovery has been undone and then not explicitly save the project before activating a close or quit command. Close or quit won't prompt for changes because the project is technically clean (though it doesn't appear to be).

Comment 2 Peter Sampson 2019-05-26 12:12:40 UTC

This is really a non-bug I'm thinking.

Yes technically this is a bug - and it would be better if recovery were precluded from Undo - but are we really bothered ?


Or maybe the "Undo" would shunt the user back to the pre-recovery dialog? I don't see the point in doing that.

This bug has sat here for nearly six years with no attempt to fix it.

I can recall no users complaining about this - and the workaround is simple, just close Audacity.

Comment 3 Peter Sampson 2019-05-29 04:27:49 UTC

Steve discussed this with me off line where he wrote
>I have an idea about how the bug should be resolved, which I'll be happy 
>to post if we decide to reopen it.

Accordingly I have re-opened this and assigned it to Steve.


The basic question - is just why we bother to put the "Recover" on the undo stack in the first place :-//

Note that if in the auto-recovery dialog the user selects "Discard Projects", there is no Undo action available for that.

Comment 4 Steve Daulton 2019-05-29 08:30:44 UTC

I think the solution here is; When a project is recovered, the initial item in the History "Create new project" should be discarded. The History then displays in the same way as when opening an existing project (which is what Audacity has done).

Comment 5 Steve Daulton 2019-07-19 08:21:39 UTC

Fix committed at 75fdadf6745e3bd18a9400905d17b48a31702bfb

Comment 6 Peter Sampson 2019-07-23 05:01:24 UTC

(In reply to Steve Daulton from comment #5)
>The basic question - is just why we bother to put the "Recover" 
>on the undo stack in the first place :-//

Testing on W10 with audacity-2.3.3-alpha-299-0bdb09eefb256ec8e378c22ba140a12110e5afad

The Recover is no longer placed on the undo stack - looks good to go on Windows

Comment 7 Peter Sampson 2019-07-25 09:06:38 UTC

Testing on macOS 10.14.5 with mac 2.3.3 alpha jc004 of 25Jul19

The Recover is no longer placed on the undo stack - looks good to go on Mac too

Comment 8 James Crook 2019-08-10 12:14:59 UTC

The Recover is no longer placed on the undo stack - looks good to go on Linux too