Bug 688 – -80 dB setting fails in Truncate Silence

••• Introduction •••
••• Keywords •••

Audacity 3.0.3 development began 19th April 2021

Audacity Bugzilla

Bug 688 - -80 dB setting fails in Truncate Silence


Summary:	-80 dB setting fails in Truncate Silence

Status:	RESOLVED FIXED

Product:	Audacity
Classification:	Unclassified
Component:	Built-in FX
Version:	2.0.6
Hardware:	PC All

Importance:	P4 Repeatable
Assigned To:	Default Assignee for New Bugs

URL:
Keywords:	patch_closed

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2013-11-17 22:38 UTC by Steve Daulton
Modified:	2018-08-20 11:51 UTC (History)
CC List:	6 users (show)

See Also:
Steps To Reproduce:
Release Note:
First Git SHA:
Group:	---
Workaround:
Closed:	2018-08-20 00:00:00

Flags:	stevethefiddle: Regression+

Attachments
Removes obsolete "skip" code. (2.48 KB, patch) 2013-11-18 19:34 UTC, Steve Daulton	Details \| Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Steve Daulton 2013-11-17 22:38:32 UTC

When the silence threshold is set to -80 dB, no silences are detected.
This is because the menu choices were changed at some point so they no longer match the expected choices in Truncate Silence,

Comment 1 Gale Andrews 2013-11-18 03:00:22 UTC

It went wrong in 2.0.1-alpha 13 March 2012 until 28 June 2012.

Comment 2 Steve Daulton 2013-11-18 07:54:59 UTC

(In reply to comment #1)
> It went wrong in 2.0.1-alpha 13 March 2012 until 28 June 2012.
A little before I think:

r11654 Removed some (hidden) Cleanspeech cruft that had been used to disable ...
April 5th 2012.

wxT("Off-Skip)" was removed from Shuttle.cpp.

Comment 3 Steve Daulton 2013-11-18 07:57:06 UTC

(In reply to comment #2)
Sorry Gale, yes, 'between' March and June. I misread.

Comment 4 Steve Daulton 2013-11-18 19:34:10 UTC

Created attachment 449 [details]
Removes obsolete "skip" code.

-80 dB option reinstated and removed the remaining obsolete "skip effect" code.

Comment 5 Steve Daulton 2013-11-18 19:38:49 UTC

This patch will clash with patches for bug 433 and bug 434.

Comment 6 Gale Andrews 2013-11-19 06:35:19 UTC

Seems OK to me. 

One question -  in Shuttle.cpp below, are we still using "Off" anywhere?

const double Enums::Db2Signal[] =
//     -20dB    -25dB    -30dB    -35dB    -40dB    -45dB    -50dB    -55dB    -60dB    -65dB     -70dB     -75dB     -80dB    Off
   { 0.10000, 0.05620, 0.03160, 0.01780, 0.01000, 0.00562, 0.00316, 0.00178, 0.00100, 0.000562, 0.000316, 0.000178, 0.0001000, 0.0 };

Comment 7 Steve Daulton 2013-11-19 12:04:39 UTC

(In reply to comment #6)
Gale wrote:
> One question -  in Shuttle.cpp below, are we still using "Off" anywhere

No I don't think that we are, so it could be removed, but I'm wondering if DbChoices and Db2Signal really belong in Shuttle.cpp

It seems odd to me that shuttle should handle just 2 Enums that are used in just 2 effects. If they were handled in the effect rather than in shuttle, this bug would not have occurred. This is something that I intend to enquire about once the dust has settled on the Truncate Silence patches.

Comment 8 James Crook 2013-11-19 13:02:56 UTC

Re Comment #6, I can answer that straight away.

The enums living in ShuttleGui was a quick piece of code to support enums at all.  I've now got an improved method for ShuttleGui where you create an ArrayString and add the enum items you need.

Comment 9 Gale Andrews 2013-11-19 18:07:08 UTC

Thanks, James and Steve. OK  I've marked "patch_ready" and the developer committing the fix can decide what to do about removing "Off".

Comment 10 Steve Daulton 2014-03-22 10:49:48 UTC

Fixed by revision: 13073