Bug 710 – Keyboard Preferences: don't match single characters in modifiers in Key View search

••• Introduction •••
••• Keywords •••

Audacity 3.0.3 development began 19th April 2021

Audacity Bugzilla

Bug 710 - Keyboard Preferences: don't match single characters in modifiers in Key View search


Summary:	Keyboard Preferences: don't match single characters in modifiers in Key View ...

Status:	RESOLVED FIXED

Product:	Audacity
Classification:	Unclassified
Component:	User Interface
Version:	2.0.6
Hardware:	Per OS All

Importance:	P4 Enhancement
Assigned To:	Default Assignee for New Bugs

URL:	https://sourceforge.net/p/audacity/ma...
Keywords:	patch_closed

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2014-03-24 01:32 UTC by Gale Andrews
Modified:	2018-08-20 11:46 UTC (History)
CC List:	5 users (show)

See Also:
Steps To Reproduce:
Release Note:
First Git SHA:
Group:	---
Workaround:
Closed:	2018-08-20 00:00:00

Attachments
David Bailes' patch to ignore single key characters in modifiers in Key View search (1.02 KB, patch) 2014-03-24 01:32 UTC, Gale Andrews	Details \| Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Gale Andrews 2014-03-24 01:32:42 UTC

Created attachment 469 [details]
David Bailes' patch to ignore single key characters in modifiers in Key View search

For example with the patch, searching for T only gives three results, so
excluding ALT- CTRL- or SHIFT-modified shortcuts that don't include T.

Comment 1 Vaughan Johnson 2014-08-01 15:59:02 UTC

Sorry, but this patch was difficult to parse, so I've modified it substantially for my commit: 

* Made the indentation and parentheses more standard and consistent.

* No need to use searchit.GetChar(searchit.Len() - 1), because wxString has a Last() method. 

* Changed the logic so there's no longer that single long negative clause. 

At revision: 13273

Comment 2 David Bailes 2014-08-02 05:37:27 UTC

(In reply to comment #1)
> Sorry, but this patch was difficult to parse, so I've modified it substantially
> for my commit: 
> 
> * Made the indentation and parentheses more standard and consistent.
> 
> * No need to use searchit.GetChar(searchit.Len() - 1), because wxString has a
> Last() method. 
> 
> * Changed the logic so there's no longer that single long negative clause. 
> 
> At revision: 13273

thanks,
David.

Comment 3 Vaughan Johnson 2014-08-03 19:57:44 UTC

(In reply to comment #2)

Thanks for the patch, David!

And to Gale for testing and confirming.