Bugzilla – Bug 715
Crash opening About Audacity in Magyar language.
Last modified: 2018-08-20 11:45:33 UTC
Crash observed on Win 7 and 8.1. No crash on OS X or Linux. No other locales tried so far crash on Windows. The crash started in 2.0.4 with the current hu.po file: http://code.google.com/p/audacity/source/browse/audacity-src/trunk/locale/hu.po?r=12351 from 1 June 2013. The crash does not happen in HEAD with the previous version of the hu.po file: http://code.google.com/p/audacity/source/browse/audacity-src/trunk/locale/hu.po?spec=svn13083&r=11422 . However the current hu.po file does not crash if used in 2.0.0 or 2.0.3 so presumably there is some root cause in the 2.0.4-alpha period ( 21 January 2013 until 05 September 2013 ) in src/AboutDialog.cpp. Changes to AboutDialog.cpp are listed here: http://code.google.com/p/audacity/source/list?path=/audacity-src/trunk/src/AboutDialog.cpp&start=13074 .
I didn't get this crash in a debug version of Audacity 2.0.6 on Win7. I made the .mo file myself from the current hu.po r12351 using poEdit. Could you post the .mo file?
Created attachment 474 [details] Audacity.mo file compiled from hu.po r12351 James wrote: > I didn't get this crash in a debug version of Audacity 2.0.6 on Win7. > I made the .mo file myself from the current hu.po r12351 using poEdit. Attached the .mo file but I made it with poedit, too. The last Audacity debug build I made in January (two months ago) doesn't crash either (Win 7) but the crash is completely repeatable in release builds.
FWIW, the crash does not occur on Mac or Linux.
(In reply to comment #1) Confirmed, not in "debug version of Audacity 2.0.6 on Win7" that James tested, but yes in Release version. But the obvious change that's visible in the debug build that doesn't crash, is that the translator has inserted him/herself in the Audacity credits list, as "Fejlesztőcsapat", above Richard Ash in the Developers list. We do not list translators there. So maybe there's a bug in the code that handles that, likely in wxWidgets handling special chars. But the actual cause is in the translator crediting him/herself as a Developer, obviously not true. That should be removed, regardless of possible bug. I think it would take me about 5x as long to fix this as somebody more conversant in fixing the .po files, so I request that, please. I think that would rapidly reduce this bug's priority to nil. Onward 2.0.6! ;-)
Fix to the hu.po file committed in r13279. (In reply to comment #4) Vaughan wrote: > But the obvious change that's visible in the debug build that doesn't crash, > is that the translator has inserted him/herself in the Audacity credits list, > as "Fejlesztőcsapat", above Richard Ash in the Developers list. Thanks, that was the line in the .po file where the problem was. The issue was a "%s" between "Audacity" and "Fejlesztőcsapat" (translation of "development team"). This caused a line break so that "Fejlesztőcsapat" looked like one of the Developers. I think the reason this crashed in 2.0.4 / 2.0.5 but not 2.0.3 was this change: https://code.google.com/p/audacity/source/detail?r=12248 - prior to that the untranslated string had the "%s". I checked all the other .po files for a "%s" inserted into those two strings that lost the "%s" in r12248, but none of the others had that issue.
(In reply to comment #5) Thanks, Gale. I guess Matt decided it long ago, but I don't see why translators get top billing above Audacity Developers! And with a bigger header?! Why is "Fejlesztőcsapat" (whatever that is) under the Audacity (implicitly Developers) heading? I guess that means Developers, but it's no longer in the header. Sorry, but I don't think this is fixed. Clearly it's no longer P1, though, so I'm demoting it.
(In reply to comment #6) And I don't see why the translator entry in this translation is apparently a full sentence, two people, and email addresses. We generally do not do that in About Dialog. I guess we can't readily monitor that, but I think it's wrong, especially as it's ahead of Developers and Support Team.
(In reply to comment #6) Vaughan wrote: > I guess Matt decided it long ago, but I don't see why translators get top > billing above Audacity Developers! And with a bigger header?! Surely OT to this bug. > Why is "Fejlesztőcsapat" (whatever that is) I have said what that is. > under the Audacity (implicitly Developers) heading? As I said, the %s caused the line break. I'm confused. Have you compiled the committed .po file, renamed the resultant .mo file to "Audacity.mo" and placed it in "Languages\hu" in your build? If not, then you will not see the change which means that Richard is again at the top of the developers list. Or does the change not show in debug builds? You can also check the next Windows -alpha build (release configuration). I'll do a build in about half an hour. > I don't see why the translator entry in this translation is apparently a > full sentence, two people, and email addresses. We generally do not do that > in About Dialog. I guess we can't readily monitor that, but I think it's > wrong, especially as it's ahead of Developers and Support Team. Again, clearly OT to this bug (crash), but if you want to review policy about this, could we start a -quality list thread?
Please compare * http://gaclrecords.org.uk/bugs/hu_po_r12351_in_debug_build.png * http://gaclrecords.org.uk/bugs/hu.po_r13279.png The only difference between those two is that in r13279 we have the header "Audacity Fejlesztőcsapat" with Richard first under that header, whereas in r12351 we have "Audacity" header with the first developer as "Fejlesztőcsapat". If you are agreeing there is no crash, should this bug not close and a new one with a relevant title open? What issue is in that bug to be?
(In reply to comment #9) > If you are agreeing there is no crash, Yes, that's what I wrote. >should this bug not close and a new one > with a relevant title open? Yes, good. Thanks.
The crash was indeed P1, but we're closing this.
I'm satisfied both the crash bug and the interface display issue in the list of developers are fixed by r13279. See the images listed in http://bugzilla.audacityteam.org/show_bug.cgi?id=715#c9 for proof. So this bug is closed and I am not proposing to start a new bug. In my opinion, where and how translators are allowed to credit themselves in About Audacity is a policy matter for Team and/or -translation and -quality lists and not an issue for bugzilla.
