Audacity Bug Summary
••• Introduction •••
••• Keywords •••
    Audacity 3.0.3 development began 19th April 2021

Audacity Bugzilla



Bug 721 - Equalization: Changing language from non-English to English creates two "unnamed" curves.
Equalization: Changing language from non-English to English creates two "unna...
Status: RESOLVED FIXED
Product: Audacity
Classification: Unclassified
Component: Built-in FX
2.0.6
Per OS All
: P4 Repeatable
Assigned To: Default Assignee for New Bugs
: patch_closed
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-05-03 14:59 UTC by Gale Andrews
Modified: 2018-08-20 11:45 UTC (History)
5 users (show)

See Also:
Steps To Reproduce:
1 Make sure Audacity Interface language is English (or System on a system running an English locale) 2 Delete EQCurves.xml in the user’s “Audacity” folder for application data. 3 Select some audio, open Equalization, make some curve change to unflatten the curve, OK. 4 Change Language to French in Interface Preferences and open “Egalisation”. 5 Make a change to the curve which changes its name from “unnamed” to “sans nom”, OK. 6 Change Language back to English, open Equalisation, note two “unnamed” choices in “Select Curve". Make a curve change, OK. 7 We now have two different “unnamed” curves in EQCurves.xml. From now on, Audacity will only read the first “unnamed” in EQCurves.xml when reopening Equalisation, so if user makes changes to that “unnamed” curve, those changes will not be shown when reopening. The user must select the "unnamed(n)" curve that was created to access their last change to “unnamed”.
Release Note:
First Git SHA:
Group: ---
Workaround:
Closed: 2018-08-20 00:00:00


Attachments
Moves the 'unnamed' curve to the end of the list (993 bytes, application/octet-stream)
2014-05-05 19:46 UTC, Martyn Shaw
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Gale Andrews 2014-05-03 14:59:22 UTC
The issue also occurs in the quite common (Windows) case where user has system language set to non-English but can't read that language, so changes Audacity interface preferences to English.
Comment 1 Martyn Shaw 2014-05-05 19:46:28 UTC
Created attachment 483 [details]
Moves the 'unnamed' curve to the end of the list
Comment 2 Martyn Shaw 2014-05-05 20:00:29 UTC
(In reply to comment #1)
The reason for this behaviour is that Audacity expects the 'unnamed' curve to be last in the list.  In any one language it is always last and there is always a last 'unnamed' curve (in the interface, there does not have to be one in an xml file being imported).

'unnamed' is translated and so a change in language will cause Audacity to make a new 'sans nom' (or whatever) and add it to the end of the list, if it does not find one there.  Then the original 'unnamed' is not at the end when the language switch back occurs, hence the problems.

So we could move the 'unnamed' curve in the current language to the end of the list (patch submitted).  That would be a step forward and clear most issues.  Users may have some unwanted curves, but they can use 'Save/Manage Curves...' to fix that.

I guess somebody working in multiple languages and wanting the 'unnamed' curve to be the same as the 'sans nom' curve and the 'unbenannt' curve (etc.) would not be satisfied.  But a more generalised fix does not come to mind, and this one should fix most problems, I hope.
Comment 3 Gale Andrews 2014-05-16 04:17:08 UTC
(In reply to comment #2)
Thanks, Martyn. I compiled your patch on Windows and Mac and it works for me so I marked it "ready".  


> I guess somebody working in multiple languages and wanting the 'unnamed' curve
> to be the same as the 'sans nom' curve and the 'unbenannt' curve (etc.) would
> not be satisfied.  

Perhaps if anyone actually asks for that we could consider it then. Perhaps do something clever when the language changes. No one has asked yet.
Comment 4 Vaughan Johnson 2014-08-01 16:15:57 UTC
(In reply to comment #3)

Committed. At revision: 13275
Comment 5 Gale Andrews 2014-08-03 08:59:39 UTC
Tests OK for me on Linux where I had not tested before, so RESOLVED - FIXED.