Bugzilla – Bug 728
All files mask wrong for Linux in some dialogues
Last modified: 2018-08-20 11:51:44 UTC
Created attachment 490 [details] Fix all files mask for Linux The mask that is currently used for "All files" in some dialogues is "*.*" This will find files "fred.txt" and "fred." and "fred.whatever" but will not find "fred" (with no dot). The proper mask to find ALL files in Linux is "*". For example, wxString(_("XML files (*.xml)|*.xml|All files (*.*)|*.*")) should be wxString(_("XML files (*.xml)|*.xml|All files (*.*)|*")) I've attached a patch which fixes all the instances I could find (I fixed an instance in NyqBench.cpp which was not noted in the feedback@ report). Patch seems OK on indows (files without extension are still found when "All files" is selected). The offending lines appear in /export/ExportFFmpegDialogs.cpp: line 1725 wxString(_("XML files (*.xml)|*.xml|All files (*.*)|*.*")), /export/ExportFFmpegDialogs.cpp: line 1745 wxString(_("XML files (*.xml)|*.xml|All files (*.*)|*.*")), /Menus.cpp: line 4660 _("Text files (*.txt)|*.txt|All files (*.*)|*.*"), /Menus.cpp: line 4705 _("MIDI and Allegro files (*.mid;*.midi;*.gro)|*.mid;*.midi;*.gro|MIDI files (*.mid;*.midi)|*.mid;*.midi|Allegro files (*.gro)|*.gro|All files (*.*)|*.*"), /prefs/KeyConfigPrefs.cpp: line 332 _("XML files (*.xml)|*.xml|All files (*.*)|*.*"), /prefs/KeyConfigPrefs.cpp: line 364 _("XML files (*.xml)|*.xml|All files (*.*)|*.*"), /prefs/KeyConfigPrefs.cpp: line 917 _("XML files (*.xml)|*.xml|All files (*.*)|*.*"), /prefs/KeyConfigPrefs.cpp: line 949 _("XML files (*.xml)|*.xml|All files (*.*)|*.*"), /LabelDialog.cpp: line 519 _("Text files (*.txt)|*.txt|All files (*.*)|*.*"), /lib-src/mod-nyq-bench/NyqBench.cpp: line 1032 _("Nyquist scripts (*.ny)|*.ny|Lisp scripts (*.lsp)|*.lsp|All files|*.*"), /lib-src/mod-nyq-bench/NyqBench.cpp: line 1078 _("Nyquist scripts (*.ny)|*.ny|Lisp scripts (*.lsp)|*.lsp|All files|*.*"),
Created attachment 491 [details] Update "All files" filters When the "All files" filter is patched to accept any file name, we are no longer just looking for "All files (*.*)" but are now looking for ALL files, so the filter description needs to also be changed. The standard label seems to be "All files" (without a wild card abbreviation), so I've updated Gale's patch with (hopefully consistent) filter descriptions for every occurrence that I could find.
Verified bug still exists in SVN rev13363 (just after 2.0.6 release) on Linux. Patch applies with fuzz and fixes the bug. As this is reported already tested on Windows, committed in SVN rev 13380. = Manual = This will make a minor appearance and behaviour change to screenshots of the various Open dialogues (Import MIDI, Labels, locate FFMpeg etc.), if (and only if) the All Files filter is selected for the screen shot or described. = Testing = This change needs testing on Mac and Windows platforms to ensure it has no unexpected effects, particularly: * That the "All Files" filter still shows all files in a directory, including those with no extension and various extensions. * That the existing filters by extension still work correctly The dialogues affected include MIDI import and Label import, as well as locating FFmpeg libraries.
(In reply to comment #1) Steve wrote: > The standard label seems to be "All files" (without a wild card > abbreviation), so I've updated Gale's patch I found Windows apps that did not observe that (i.e. they use the wild card) hence I was unsure about the change. I don't feel strongly about it but it should be pointed out.
No impact on the Manual, tested on Mac and retested on Win.
