Bug 733 – TimeText controls incorrectly showing all zeros

••• Introduction •••
••• Keywords •••

Audacity 3.0.3 development began 19th April 2021

Audacity Bugzilla

Bug 733 - TimeText controls incorrectly showing all zeros


Summary:	TimeText controls incorrectly showing all zeros

Status:	RESOLVED FIXED

Product:	Audacity
Classification:	Unclassified
Component:	User Interface
Version:	2.0.6
Hardware:	PC All

Importance:	P3 Repeatable
Assigned To:	Default Assignee for New Bugs

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2014-06-12 14:56 UTC by Steve Daulton
Modified:	2018-08-20 11:45 UTC (History)
CC List:	6 users (show)

See Also:
Steps To Reproduce:
Release Note:	Some Time Controls are not updated and always show zero. The Label Editor shows label times as zero and the Repeat effect shows the new duration as zero. Workaround: Refer to the Timeline or Selection toolbar to manually calculate the correct times.
First Git SHA:
Group:	---
Workaround:
Closed:	2018-08-20 00:00:00

Flags:	stevethefiddle: Accessibility+ stevethefiddle: Regression+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Steve Daulton 2014-06-12 14:56:52 UTC

* "Effect > Repeat" shows all zeros as the new length.

* In a project that has labels, open the Label Editor. Label times are all shown as zeros.

The bug appeared in r13138 "Fixes some minor issues reported by valgrind."

In src/widgets/TimeTextCtrl.cpp the order of calling
    SetTimeValue(timeValue);
    SetFormatName(formatName);
is critical. The reordering in r13138 breaks updating the TimeText controls.

Swapping the order back fixes the problem, but obviously I don't want to reintroduce the issue that this was intended to fix.

Marked as P3 because for user's it is multiple regressions.

Comment 1 Leland Lucius 2014-06-12 19:11:31 UTC

Oh, oh...I'll take a look since this was my fault.

Comment 2 Gale Andrews 2014-06-13 06:20:32 UTC

Committed in r13199: SetTimeValue(timeValue); moved back below SetFormatName(formatName); .

Comment 3 Gale Andrews 2014-06-18 06:45:24 UTC

Seems OK to me, I tested it on Mac and Windows with different selection formats.