Bugzilla – Bug 753
Sort Tracks by Name may misbehave with stereo tracks.
Last modified: 2018-08-20 11:45:46 UTC
Created attachment 505 [details] First of two possible fixes. I have written two different fixes for this. It might be desirable to take both. The first fix renames the right channel track at the time tracks are linked to form a stereo track, instead of postponing that renaming until such time as the tracks are split again. An incorrect comment in the code said the old name is preserved. Was that the intention or not? Should there be no renaming at all? If none, then the other patch should be taken for this bug.
Created attachment 506 [details] Second possible fix. It may make sense to take both patches. This other way of fixing the bug corrects the sorting routine so that it does not make the hidden assumption that linked tracks always have the same name. Instead, the second track of a linked pair is ignored when determining where the insertion sort inserts.
(In reply to comment #1) > Second possible fix. [...] the second track of a linked pair is ignored when > determining where the insertion sort inserts. Personally I prefer the second fix (but I have not tried either). In any case I strongly oppose the renaming of the right channel as done in the current code :=) See http://audacity.238276.n2.nabble.com/Channel-Naming-WAS-Re-Record-a-subset-of-Channels-preset-Channel-Names-td7556956.html .
DEVEL - FIX MADE https://github.com/audacity/audacity/commit/fab1a2778b31e431a7feaf7d899f62dbcd395682
(In reply to James Crook from comment #3) Testing on macOS Sierra 10.12.6 db97fea 15Aug Testing using the steps: the A-C created stero track remains as is - and the B track remains as a mono track. Looks to be fixed ok on Mac
RESOLVED FIXED per comment 4.