Bug 766 – Corrupted device names when running non-English system language

••• Introduction •••
••• Keywords •••

Audacity 3.0.3 development began 19th April 2021

Audacity Bugzilla

Bug 766 - Corrupted device names when running non-English system language


Summary:	Corrupted device names when running non-English system language

Status:	RESOLVED FIXED

Product:	Audacity
Classification:	Unclassified
Component:	User Interface
Version:	2.0.7
Hardware:	Mac macOS

Importance:	P2 Repeatable
Assigned To:	Default Assignee for New Bugs

URL:	http://forum.audacityteam.org/viewtop...
Keywords:	patch

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2014-10-05 02:09 UTC by Leland Lucius
Modified:	2018-08-20 11:45 UTC (History)
CC List:	5 users (show)

See Also:
Steps To Reproduce:	1) Set system language to French 2) Reboot 3) Start Audacity 4) Go into Preferences 5) Select Devices page The device names will appears to be corrupted.
Release Note:
First Git SHA:
Group:	---
Workaround:
Closed:	2018-08-20 00:00:00

Flags:	leland: Regression+

Attachments
Example of corrupted device names (207.60 KB, image/png) 2014-10-05 02:09 UTC, Leland Lucius	Details
Example of corrected device names (204.24 KB, image/png) 2014-10-05 02:10 UTC, Leland Lucius	Details
Fix for incorrect translation of UTF8 device names (10.89 KB, patch) 2014-10-05 02:10 UTC, Leland Lucius	Details \| Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Leland Lucius 2014-10-05 02:09:31 UTC

Created attachment 510 [details]
Example of corrupted device names

User reported:

Comment 1 Leland Lucius 2014-10-05 02:10:05 UTC

Created attachment 511 [details]
Example of corrected device names

Comment 2 Leland Lucius 2014-10-05 02:10:57 UTC

Created attachment 512 [details]
Fix for incorrect translation of UTF8 device names

Comment 3 Leland Lucius 2014-10-05 02:17:13 UTC

The problem is that the strings returned from PortAudio were not being handled properly.  On OSX (and maybe Linux), the strings may be in UTF8 and the current handling does not take that into account.

Utilizing wxWidgets wxSafeConvertMB2WX() function should allow handling of either UTF8 or plain ASCII.

Comment 4 Gale Andrews 2014-10-07 04:34:03 UTC

Thanks, Leland. The fix cures the corruption, but there is truncation of the translated text. For example in French the playback device in Device Toolbar says "Sortie intégr" when it should be "Sortie intégrale". In Czech we have for Built-in audio playback "Vestavêný vý" instead of "Vestavêný výstup". 

Can we do anything about the 12 character limitation?

Comment 5 Leland Lucius 2014-12-06 00:07:30 UTC

I've applied the patch attached to this report and have also committed an upstream patch for the device name truncation.

Comment 6 Leland Lucius 2014-12-06 00:08:06 UTC

Revisions r13698 and r13699

Comment 7 Gale Andrews 2015-02-11 16:19:39 UTC

Confirmed fixed, tested Japanese and French on Yosemite and Czech on Mavericks. Correct language is shown and no truncation.