Bugzilla – Bug 767
Incorrect Use of uncapitalised rms in Contrast and project files.
Last modified: 2018-08-20 11:51:53 UTC
Created attachment 513 [details] Capitalises RMS in Contrast and project files. It was agreed in cited thread to use RMS (capitalised) consistently where users can see it. Attached patch makes Contrast GUI and exported text file use RMS. Also (if wanted) it makes the AUP/AUTOSAVE file write "RMS" instead of "rms". I tested it with recording and On-Demand Import, but obviously if we do want that, please check how it's been done.
The UI changes have been committed in SVN rev 13431 There is no way the project file changes are going in, because they will break compatibility, for no user-facing gain. The issue that started this was consistency in the UI. The project files do not constitute part of the UI, so no need to change them. == Manual == The Contrast tool screenshot will need updating as the text has (minor) changed. May also affect associated page. == Testing == This is a UI string change so does not require specific testing as the affected strings have now been changed.
Richard wrote: > There is no way the project file changes are going in, because > they will break compatibility Fair enough, though I'll admit I'm not sure exactly what you mean. AFAICT, any 1.3.x or later release of Audacity will open a project saved by Audacity compiled with those changes, will save over that project, which can then be opened by the patched build and saved over. > for no user-facing gain. There is a small amount of user-facing gain. Most days on the Forum we have to direct a user to open the AUP file or the AUTOSAVE file in a text editor to rescue some problem they are having, or we might post an example AUP to show the AUP structure. If we ever documented the project structure in the Manual, which arguably we should, "rms" would be inconsistent.
Updated the Manual and removed "manual" keyword. The Manual now has tracking for all code changes, not just bugs at http://manual.audacityteam.org/man/Code_Review_2.0.7 (or whatever the version is) so we may not need this keyword.
