Bugzilla – Bug 768
Regular Interval Labels may return fewer labels than requested.
Last modified: 2018-08-20 11:45:48 UTC
Steps to reproduce: 1) Generate 30 seconds of audio and select it. 2) Set Label Interval to 12 seconds. 3) Set "Add final label" to "No" 4) Set "Adjust label interval to fit length" to "No". Expected result: Labels at times 0, 12 and 24 seconds. Actual result: Labels at times 0 and 12 seconds only. The description in the manual says: "Choose whether or not to place an extra label at the end of the selected audio." In this case, selecting "Yes" creates the expected number of labels and setting to "No" creates one less than the expected number. In what sense is a label at 24 seconds an "extra" label?
(In reply to comment #0) In the case of fitting the labels, what happens when you add a final label makes sense. It adds an "extra" label that is optional (and probably only useful if you select part of the audio). In the case of not fitting the labels with final label = "No", we want labels at 0s, 12s and 24s, as you say. Setting final label = "Yes" could either add a label at the end of the selection (what it does if "Number of labels" is chosen, and what the Manual implies). Or, we could add another label (at 36s in the test case). Or, drop the "Final label" idea (as I think you want, but I am not totally sure). Until then, I would argue for P3 on this.
Fixed in https://github.com/audacity/audacity/commit/2b403f15 Marked Devel-Fix Made
Testing on Mac El Capitan on 01a95c5-2.1.3-alpha-13-feb-16 and Testing on W10 on aud audacity-win-rf933621-2.1.3-alpha-19-feb-16 Tests ok on both platforms: labels ceated at 0, 12 and 24 seconds as expected. Note thet tnere is now now ""Add final label" in tge dialog - this is intentional and by design.
Tests OK on 396a6f0 from audacity/audacity on Linux: labels created at 0, 12 and 24 seconds as expected. Flagging this as Test-OK-Lin. "Note that there is now no "Add final label" in the dialog"?
Tests OK for me trying a few other tests on Windows.
