Bug 773 – ENTER activates effect when OK button is greyed out

••• Introduction •••
••• Keywords •••

Audacity 3.0.3 development began 19th April 2021

Audacity Bugzilla

Bug 773 - ENTER activates effect when OK button is greyed out


Summary:	ENTER activates effect when OK button is greyed out

Status:	RESOLVED FIXED

Product:	Audacity
Classification:	Unclassified
Component:	Built-in FX
Version:	2.0.7
Hardware:	Other Linux

Importance:	P3 Repeatable
Assigned To:	Default Assignee for New Bugs

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2014-10-22 19:19 UTC by Steve Daulton
Modified:	2018-08-20 11:51 UTC (History)
CC List:	6 users (show)

See Also:
Steps To Reproduce:	1) Generate a tone, amplitude 0.8 2) Effect menu > Normalize 3) Set the normalize level to a positive value. The OK and Preview buttons are greyed out. 4) Press ENTER The Normalize effect is applied with the (invalid) positive setting
Release Note:	GROUP: Effects and Analysis * (Linux) ENTER applies an effect even if its OK button is grayed out due to invalid input.
First Git SHA:
Group:	---
Workaround:
Closed:	2018-08-20 00:00:00

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Steve Daulton 2014-10-22 19:19:19 UTC

This applies to all effects that grey out the OK button when user input is invalid.

In many cases, the OK button is greyed out to prevent Audacity crashing/freezing with invalid input, so it should probably be rated as quite high priority.

Found to occur in 2.0.7 and 2.0.1 on Linux.
Does not happen on Windows XP.

Comment 1 Gale Andrews 2014-10-27 18:55:18 UTC

Linux only.

Comment 2 Leland Lucius 2014-12-06 14:01:11 UTC

Steve, does this still happen for you?  I can't get it to happen here...

Comment 3 Steve Daulton 2014-12-06 18:58:24 UTC

(In reply to comment #2)
Yes, it still happens here with revision 13706 debug with the "steps to reproduce".

Comment 4 Leland Lucius 2014-12-12 03:53:50 UTC

Fix (workaround) committed in r13745.

Comment 5 Gale Andrews 2014-12-12 17:46:39 UTC

Leland, you are "allowed" (and it saves time) to move bugs to "DEVEL - FIX MADE" when you commit a fix (just not to move it to "RESOLVED - FIXED"). :=)

Comment 6 Leland Lucius 2014-12-12 19:31:50 UTC

Cool.  I wondered about that.  I will start doing it.