Bug 795 – Inconsistent append-record behavior, depending on selection

••• Introduction •••
••• Keywords •••

Audacity 3.0.3 development began 19th April 2021

Audacity Bugzilla

Bug 795 - Inconsistent append-record behavior, depending on selection


Summary:	Inconsistent append-record behavior, depending on selection

Status:	RESOLVED FIXED

Product:	Audacity
Classification:	Unclassified
Component:	Audio IO
Version:	2.0.7
Hardware:	PC Other

Importance:	P3 Repeatable
Assigned To:	Default Assignee for New Bugs

URL:
Keywords:	patch_closed

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2014-12-13 08:17 UTC by Paul L
Modified:	2018-08-20 11:45 UTC (History)
CC List:	5 users (show)

See Also:
Steps To Reproduce:	1. In Recording preferences, turn overdub on, and make latency correction large, like +2000. 2. Generate some sound, so the project has one and only one track. 3. Select whole track, append-record a few seconds, and stop: notice there is no latency correction. 4. Deselect all (ctrl-shift-a), append-record, and stop: latency correction happens (as 2 seconds of inserted silence).
Release Note:
First Git SHA:
Group:	---
Workaround:
Closed:	2018-08-20 00:00:00

Attachments
Patch for bug 795 (1.43 KB, patch) 2014-12-13 08:40 UTC, Paul L	Details \| Diff
Fix an error in the previous fix (1.32 KB, application/octet-stream) 2015-01-10 11:43 UTC, Paul L	Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Paul L 2014-12-13 08:17:17 UTC

The correct behavior is #3, agreed?  Latency correction with overdub recording is meant to synchronize recording with playback, but there was no playback.

I know what code causes this and I can prepare a fix.

I discovered this when I attempted to implement punch and roll recording.

Comment 1 Paul L 2014-12-13 08:40:05 UTC

Created attachment 524 [details]
Patch for bug 795

Comment 2 Bill Wharrie 2015-01-04 11:53:55 UTC

(In reply to comment #1)
It appears this patch has not been committed?

Comment 3 Leland Lucius 2015-01-04 14:46:57 UTC

Committed in r13851

Comment 4 Paul L 2015-01-10 11:41:41 UTC

My fix was not quite right!  A compilation warning alerted me to the mistake.

Comment 5 Paul L 2015-01-10 11:43:15 UTC

Created attachment 539 [details]
Fix an error in the previous fix

Here is the correction.

Comment 6 Leland Lucius 2015-01-10 13:17:15 UTC

Committed in r13874.