Bugzilla – Bug 81
"Advanced Mixing Options": Names of all input tracks scaled unreadably small if any input tracks have a long name
Last modified: 2018-08-20 11:45:41 UTC
Created attachment 355 [details] Limits displayed name length To prevent the name being resized too small to read, the displayed track name will be limited to a maximum of 20 characters for mono tracks and 20 characters + " - L" or " - R" for Left/Right channels.
Thanks, Steve. Tests fine on Windows 7 and Mountain Lion as far as the intention goes, so marked "patch_ready". As far as the track and channel names really being readable without magnification, I suggest there needs to be more done (a new bug). * Use a sensible background colour for the track that has some contrast with the black text e.g. try the track selected colour in Track Control Panel. If it's felt track and channel backgrounds need to be very different, try the track unselected colour as the background colour for channels. * Make the boxes wider. Why waste that space to left and right of the window? If it is mandatory that the boxes are the same width, make the channel box text "Output Channel:". * Consider a vertical scrollbar for the window if > 16 tracks or > 16 channels. I can't read the text on Windows if those conditions are true. If we had a vertical scrollbar, maybe we could have text wrap to a taller box for long text, instead of truncation?
Created attachment 358 [details] "Tracks" box color lighter than previous patch Making the colour of the tracks boxes a bit lighter is a minor change so I've added it to this patch.
(In reply to comment #3) > Making the colour of the tracks boxes a bit lighter is a minor > change so I've added it to this patch. The colour is certainly more readable thanks, though the effect is a bit dowdy-looking on Windows. In any case it doesn't work on Mac - the track box has jet black background and the text is unreadable.
(In reply to comment #4) > In any case it doesn't work on Mac - the track box has jet black background > and the text is unreadable. Thanks for testing. Reverting to the original patch. I've marked the "Tracks box color" patch obsolete and un-obsoleted the original patch. If changing the color is sufficiently important to raise a bug then I think it needs to be a new bug and the platform differences taken into account.
> Consider a vertical scrollbar for the window if > 16 tracks or > 16 channels. I doubt that it is common to export more than 16 channels, but the window can be resized in such cases so I don't think that a scroll bar is really necessary. I agree that a light background colour for the Track box would be preferable, but not required for fixing the stated bug. I think this was marked "patch_ready" before my (now reverted) change to the colour, so I've returned it to patch_ready.
Steve, I committed the patch, modified as follows, per standard C++ code conventions: * If a local var is assigned when declared, it's clearer to put it in one statement, or at least consecutive statements. And if it's not going to change later in the method, it's good to make that clear, declare it "const". * Variables and parameters should start with lower case. "s" prefix is a standard for string vars/params. Methods/functions start with upper case. * In C and C++, stuff like "if( bool )" is much more traditionally written as "if (bool)". I'm sure others will be religiously devoted to "if( bool )" or whatever. I'm just telling the tradition, and for stuff like that, I think there's scant reason to subvert the tradition.
RESOLVED-FIXED New bug for background colours and usability created at bug 623.