Bugzilla – Bug 899
WahWah effect produces NaNs when resonance set to zero.
Last modified: 2018-08-20 11:51:43 UTC
Leland reported a divide by zero error: https://sourceforge.net/p/audacity/mailman/message/33621856/ Problem confirmed and repeatable on Linux. Initially marked as P4.
Yes it's cross-platform and not related to length of the selection.
This bug can be closed as input validation now prohibits setting resonance to zero.
(In reply to Steve Daulton from comment #2) > This bug can be closed as input validation now prohibits setting resonance > to zero. OK thanks WONTFIX is nearest to intention I think. It might be an idea to comment line 48 in Wahwah.cpp that a setting of 0 causes bug 899, just in case the policy on input validation ever changes.
(In reply to Gale Andrews from comment #3) Doesn't "WONTFIX" imply that the problem (bug) still happens but we are are not going to fix it? That's not the case. The problem (bug) does not happen now. The problem was because of "divide by zero" when resonance was set to zero. As a value of zero cannot now be set, this bug is FIXED.
(In reply to Steve Daulton from comment #4) What I was trying to convey was that WahWah would be able to produce NaN's if validation was removed or made user-specifiable, as has been suggested a few times on the Forum in response to "complaints". WahWah would be able to produce Nan's if a developer changed the range to start from 0. Hence why I suggested commenting the code. So as titled the bug is I think not fixed. It has perhaps become INVALID, but it was not INVALID to begin with, so I did not want to use that. If the title was "Wahwah can produce NaN's", then it's fixed, but I think it better reflects the situation left as is. WONTFIX means NONEEDTOFIX.
