Bug 923 – LADSPA effect settings not saved when computer uses comma-separated locale.

••• Introduction •••
••• Keywords •••

Audacity 3.0.3 development began 19th April 2021

Audacity Bugzilla

Bug 923 - LADSPA effect settings not saved when computer uses comma-separated locale.


Summary:	LADSPA effect settings not saved when computer uses comma-separated locale.

Status:	RESOLVED FIXED

Product:	Audacity
Classification:	Unclassified
Component:	LADSPA
Version:	2.1.1
Hardware:	Per OS Windows (all)

Importance:	P3 Repeatable
Assigned To:	Default Assignee for New Bugs

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2015-04-29 21:06 UTC by Gale Andrews
Modified:	2018-08-20 11:51 UTC (History)
CC List:	5 users (show)

See Also:
Steps To Reproduce:	1 Ensure Audacity is set to "System" language then exit Audacity. 2 Install the LADSPA-swh plugins if you have not yet done so. 3 Change Windows "Region and Language" Format to French or to other locale where comma is the decimal separator. 4 Delete pluginsettings.cfg. 5 Launch Audacity, add some audio and select a LADSPA plugin e.g. Reverse Delay (5s max). 6 Move some effect sliders around, then from the Manage menu, choose Factory Presets > Defaults. Sliders don't change. 7 Save the current settings as a User Preset, move the sliders, reselect the User Preset that you saved. Sliders don't change. 8 Apply and Close the effect. 9 Restart Audacity. Open the same effect you were testing. Slider positions are defaults instead of the settings present at step 8.
Release Note:	GROUP: Effects (LADSPA) * (Windows) When Region and Language format for the computer is set to a language using comma as decimal separator (for example, French or German), effect settings cannot be changed from the Manage menu to Factory Defaults or to saved User Presets. Also, current settings are not saved after Audacity is quit.
First Git SHA:
Group:	---
Workaround:
Closed:	2018-08-20 00:00:00

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Gale Andrews 2015-04-29 21:06:14 UTC

Not tested other than on Windows. 

Languages that use comma separator are not affected. 

Built-in and VST effects are not affected. 

A user running Windows in French Region and Language says that if a LADSPA slider is moved, then a second slider is moved, then sometimes the first slider reverts to its original position. However I cannot reproduce that.

Comment 1 Gale Andrews 2015-04-29 21:09:10 UTC

(In reply to Gale Andrews from comment #0)
> Languages that use comma separator are not affected. 
Sorry -  that meant that languages that use period as decimal separator are not affected.

Comment 2 Leland Lucius 2015-06-02 15:08:04 UTC

This actually does affect LADSPA, VST, LV2, and Audio Units.  I have a fix ready and will commit, but it means that the settings saved in 2.1.0 will not load in 2.1.1.  The user will have to redo them.

Comment 3 Leland Lucius 2015-06-02 19:31:14 UTC

Fix committed in 7d359ef0100dc726c66fcc22d2302347412cfd12

Comment 4 Gale Andrews 2017-03-16 21:31:35 UTC

(In reply to Leland Lucius from comment #2)
> This actually does affect LADSPA, VST, LV2, and Audio Units.  
Well, I tested those and the subject issue of this bug is fixed but we have the new bug 1604 for LV2 (occurs regardless of locale) and 1605 for AU (which is related to locale).