Bug 955 – Sliding Time Scale preview incorrect.

••• Introduction •••
••• Keywords •••

Audacity 3.0.3 development began 19th April 2021

Audacity Bugzilla

Bug 955 - Sliding Time Scale preview incorrect.


Summary:	Sliding Time Scale preview incorrect.

Status:	RESOLVED FIXED

Product:	Audacity
Classification:	Unclassified
Component:	Built-in FX
Version:	2.1.1
Hardware:	Per OS All

Importance:	P4 Repeatable
Assigned To:	Clayton Otey

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2015-05-17 20:24 UTC by Steve Daulton
Modified:	2018-08-20 11:45 UTC (History)
CC List:	7 users (show)

See Also:
Steps To Reproduce:
Release Note:
First Git SHA:
Group:	---
Workaround:
Closed:	2018-08-20 00:00:00

Flags:	petersampsonaudacity: Test‑OK‑Win+ petersampsonaudacity: Test‑OK‑Mac+ gale: Test‑OK‑Lin+

Attachments
initial patch for bug 955 (14.52 KB, patch) 2016-01-21 03:20 UTC, Clayton Otey	Details \| Diff
patch revision 1for bug 955 (15.00 KB, patch) 2016-01-23 20:54 UTC, Clayton Otey	Details \| Diff
Show Obsolete (1) Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Steve Daulton 2015-05-17 20:24:57 UTC

The Preview does not match the effect if the preview length is different from the selection length.

This is the same problem as occurred with the previous attempt to add Preview to this effect (see: bug 271#c5)

Comment 1 Steve Daulton 2015-12-13 00:47:51 UTC

Clayton Otey has agreed to take this one on, so assigned to him.

Comment 2 Clayton Otey 2016-01-21 03:20:18 UTC

Created attachment 661 [details]
initial patch for bug 955

Attached a patch that calculates stretch parameters so that the resulting slide trajectory is that same as would be applied, but the output duration is limited by the preview length.  Note this is non-trivial and changes lib-src/sbsms (i updated lib-src/audacity-patches.txt to reflect this).

Comment 3 Clayton Otey 2016-01-23 20:54:20 UTC

Created attachment 662 [details]
patch revision 1for bug 955

An updated patch which also changes m4/audacity_checklib_libsbsms.m4 to check for a newer version of sbsms (2.2.0) so that the local library is used on linux, until sbsms 2.2.0 is released upstream.

Comment 4 Steve Daulton 2016-01-26 23:03:40 UTC

Clayton's patch committed.
https://github.com/audacity/audacity/commit/954bb0f
Marked "Fix Made".

Comment 5 Peter Sampson 2016-02-20 09:16:02 UTC

Testing on Mac El Capitan on 01a95c5-2.1.3-alpha-13-feb-16
and
Testing on W10 on aud audacity-win-rf933621-2.1.3-alpha-19-feb-16


Preview works as expected on both platforms - working on a 30 second tone with a default preview length of 6 seconds.

Looks to be fixed.

Comment 6 Gale Andrews 2016-12-20 18:59:36 UTC

seems OK with non-default 3 seconds preview on Ubuntu.