Bugzilla – Bug 964
Windows 7: Support data generated if quitting using task manager when "About Audacity" is open.
Last modified: 2019-06-10 06:08:55 UTC
2.0.0 and 2.1.0 also crash on Mac and Linux so a long standing issue. Also crashes on Mac if audio is added before quit but for Mac that step is not needed to provoke the crash. On Windows, right-click > Close window over the Audacity icon in the Taskbar does not quit or prompt for changes when About Audacity is open. This appears to be usual behaviour on Windows when the app has a modal window open.
I think you are correct about associating this and 1174. What I was finding last night was that if the Nyquist Workbench window is left open and then you "COMMAND+Q", Audacity would crash during shutdown. All of these may possibly be related.
I see what's going on and can probably come up with a simple "workaround". It has to do with the wxEVT_QUERY_END_SESSION and wxEVT_END_SESSION events being used instead of the normal wxEVT_CLOSE_WINDOW. It's supposed to do that in these instances, but we haven't handled it properly. But, I'd like to leave the ticket open since the whole application quit process needs to be reworked. It has gotten unnecessarily complicated over the years.
Workaround committed in https://github.com/audacity/audacity/commit/49fc3336eb8463602c39f85416b05768f134832e and https://github.com/audacity/audacity/commit/484e8c50147138c1ec1de14142d4664fe36ee0fa
As Leland pointed out in Comment 2, the crashes on Mac with About Audacity open have been worked around, but steps to reproduce have been retained as he requested. So this is currently a Windows-only bug. Title changed from "Crash on Quit with "About Audacity" open (changes are saved OK before the crash)" to "Windows: "About Audacity" causes safe crash on quit, or prevents quit". Steps to reproduce and release note updated.
*** STEPS UPDATED *** This is a Windows 7 AND Windows 10 problem, so title updated.
I'm failing to see the problem here. With 2.3.0 RC2 1) Run Audcity 2) get some Audio 3) invoke Help > About Audacity 4) launch Windows Task manger 5) select Audacity and use the "End Task" button 6) Audacity aborts (as intended) - 7) I get no "Save Project" dialog 8) relaunch Audacity 9) automatic recovery is offered an works fine I think this is expected behavior - using task Manager to "close" Audacity is an unusual and not recommended way of closing a project - it's an "abort" (it's not a recommended way to gracefully close ANY app). And on 2.3.0 RC2 on Mac, Force Quit is also an "abort" and the similar steps produce the same resukt.
(In reply to Peter Sampson from comment #6) > I'm failing to see the problem here. In steps to reproduce, the section: Windows 7 crash - (In Windows 10, Task Manager seems to force quit applications): this only applies to Windows 7, and I can reproduce this with 2.3.0 RC2. But how many people are going to do this? Doesn't seem very important to me. the section: Windows 7 or 10 About Audacity prevents quit from Task Bar icon: I think this is normal behaviour, and so not a bug. > > With 2.3.0 RC2 > 1) Run Audcity > 2) get some Audio > 3) invoke Help > About Audacity > 4) launch Windows Task manger > 5) select Audacity and use the "End Task" button > 6) Audacity aborts (as intended) - > 7) I get no "Save Project" dialog > 8) relaunch Audacity > 9) automatic recovery is offered an works fine > > I think this is expected behavior - using task Manager to "close" Audacity > is an unusual and not recommended way of closing a project - it's an "abort" > (it's not a recommended way to gracefully close ANY app). > > > And on 2.3.0 RC2 on Mac, Force Quit is also an "abort" and the similar steps > produce the same resukt.
There are many other things that prevent W10 from closing an Audacity Window from the Task bar, the File>Close menu - or the closes obtainable by clicking on the top left Audacity icon or the top right "X": a) open EGA dialogs b) open error message dialogs c) open Nyquist dialog d) Open Preferences dialogs e) Edit>Metadata dialog open f) etc. These are normal and expected behaviors - if one insiste on closing in that state one either has to close the dialog and then close audacity - or adopt the sledgehammer abort from Task Manager - which exits safely enough, offering to restore the project on restart. I agree with David that as the actual "bug" logged here is restricted to W7 - so I shall leave this bug open but reduce its priority to P5.
*** STEPS UPDATED *** Removed steps involving not closing Audacity from task bar (when a dialog such as About Audacity is open). Testing on other apps shows that this is common behaviour.
I can no longer test this as I have W10 (and XP) but not W7. This problem will disappear in early 2010 when Microsoft make W7 End-Of-Life
Nyquist Workbench has been declared obsolete for Audacity 2.3.3 onwards. there is a Proposal for a replacement: https://wiki.audacityteam.org/wiki/Proposal_Nyquist_IDE >Proposal Nyquist IDE
Correction This problem will disappear in early 2020 when Microsoft make W7 End-Of-Life
a) this is W7 which becomes End-Of-Life in early 2020 b) using force quit is not the "usual way" of closing Audacity - especially when "About Audacity" is open c)it looks like a Microsoft W7 problem and not an Audacity one No one will fix this in the remaining few months of W7 (9it hasn't been touched for 4 years now)
