Bugzilla – Bug 981
Enabled Nyquist Workbench creates a redundant disabled effect in Register Effects.
Last modified: 2018-08-20 11:51:23 UTC
Mod-script-pipe does not create a disabled "effect".
Actually, that's an effect that Nyquist Workbench uses behind the scenes. It was never visible before because we never saw what effects were "active" outside if the scan dialog at Audacity startup. I'd leave this here though cause there might be a way to get rid of it by "hooking" into the updated Nyquist Prompt. But, in that case it would be an enhancement rather than a P4.
If it's necessary to show the worker in Register Effects it seems to me that the way it's handled there is close to a bug. Should it not be enabled and when it is selected, the "Disable" button is greyed out? Come to that, would it be an idea generally to grey out "Enable" for an Enabled effect, and grey out "Disable" for a disabled effect? It would reduce the number of active choices the user has to take in.
(In reply to Gale Andrews from comment #2) > If it's necessary to show the worker in Register Effects it seems to me that > the way it's handled there is close to a bug. Should it not be enabled and > when it is selected, the "Disable" button is greyed out? > I'd actually prefer it didn't show up in the dialog, but there's now easy way to make an exception just for this fella. Wait...I've just had an idea. Let me try it to see if it'll work. Will have to be after dinner though. Belly comes first. :-) > Come to that, would it be an idea generally to grey out "Enable" for an > Enabled effect, and grey out "Disable" for a disabled effect? It would > reduce the number of active choices the user has to take in. Not a bad idea, for the "Disabled" and "Enabled" categories, but the "All" and "New" fellas will have to have both enabled. The "All" fella allow multi-selection, so you wouldn't no which buttons to "grey". The "New" category would allow either Disable or Enable, so neither can be disabled there.
Fix committed in b8ce7f6 for the bug...will look into greying the dialog buttons shortly.
(In reply to Leland Lucius from comment #4) On Ubuntu 14.04 32-bit Register Effects now has two Nyquist Prompts: * Nyquist Prompt... which looks like the Effect Menu item because of the ellipse but is the Workbench item I guess. It appears to be capable of being enabled but enabling it leaves it disabled next time you open Register Effects. * Nyquist Prompt (which is the Nyquist Prompt). I know you are still to look into button greying but is that what I am supposed to be seeing?
(In reply to Gale Andrews from comment #5) It's OK if I delete all the .cfg files, then I just see unellipsed Nyquist Prompt for the actual Nqyuist Prompt.
(In reply to Gale Andrews from comment #5) > (In reply to Leland Lucius from comment #4) > On Ubuntu 14.04 32-bit Register Effects now has two Nyquist Prompts: > > * Nyquist Prompt... which looks like the Effect Menu item because of the > ellipse but is the Workbench item I guess. It appears to be capable of being > enabled but enabling it leaves it disabled next time you open Register > Effects. > > * Nyquist Prompt (which is the Nyquist Prompt). > > I know you are still to look into button greying but is that what I am > supposed to be seeing? Actually, that extra one with the "..." is from 2.1.0. I'm still struggling to get 2.1.0 and 2.1.1 to play nice together with the pluginregistry.cfg. I will prevail, I just need to "forget" about it for a day or two and then I'll hit it again.
Testing on Ubuntu with the latest Audacity 2.3.0 alpha, this appears to be fixed.
