Bug 989 – Stop-and-set-cursor is imprecise

••• Introduction •••
••• Keywords •••

Audacity 3.0.3 development began 19th April 2021

Audacity Bugzilla

Bug 989 - Stop-and-set-cursor is imprecise


Summary:	Stop-and-set-cursor is imprecise

Status:	CLOSED WORKSFORME

Product:	Audacity
Classification:	Unclassified
Component:	User Interface
Version:	unspecified
Hardware:	PC Other

Importance:	P4 RepeatableAll
Assigned To:	Paul L

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2015-05-29 10:24 UTC by Paul L
Modified:	2019-05-27 10:38 UTC (History)
CC List:	5 users (show)

See Also:
Steps To Reproduce:	Generate a click track. Hit the play/stop-and-set-cursor key repeatedly, so you advance through the track in halting steps. I do not hear every click when I do this. The time at which you restart is slightly after the last time played back, enough to skip an entire click.
Release Note:
First Git SHA:
Group:	---
Workaround:
Closed:	2019-05-27 00:00:00

Flags:	petersampsonaudacity: Test‑OK‑Win+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Paul L 2015-05-29 10:24:13 UTC

I think I can figure this one out.

Comment 1 Paul L 2015-05-29 10:35:21 UTC

This was observed on Windows.  I can't speak for the others.

Comment 2 Paul L 2015-05-29 11:34:24 UTC

I tried a few things and I am less confident of a fix.

Comment 3 Paul L 2015-05-29 12:40:31 UTC

Aha!  AudioIO::StopStream() calls Pa_AbortStream().  Change that to Pa_StopStream().  That waits to flush the output our callback has written, rather than discarding it.  That may make a difference of tens of millliseconds of play.  That solves part of the problem, the missing playback.

But I think there may be remaining reasons for imprecision of the stopping point.

Comment 4 Peter Sampson 2019-05-27 10:38:05 UTC

Testing on W10 with audacity-2.3.3-alpha-256-ac65d817acdc76466af9f49b1681e1abf2c39fc0

Following the Steps this works fine.

Alos I use "X" shortcut a 8lot* in Real-Life production work and I never notice any imporecision